All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Hauke Mehrtens <hauke@hauke-m.de>, emmanuel.grumbach@intel.com
Cc: ilw@linux.intel.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] iwlwifi: fix requested firmware name for iwlwifi-3160
Date: Tue, 22 Sep 2015 10:44:36 +0200	[thread overview]
Message-ID: <1442911476.2018.2.camel@sipsolutions.net> (raw)
In-Reply-To: <1442659190-6060-1-git-send-email-hauke@hauke-m.de> (sfid-20150919_124007_995516_62A820AE)

On Sat, 2015-09-19 at 12:39 +0200, Hauke Mehrtens wrote:
> modinfo iwlwifi showed the following required firmware:
> firmware: iwlwifi-3160-IWL3160_UCODE_API_OK.ucode

This is obviously wrong.

> 
>  MODULE_FIRMWARE(IWL7260_MODULE_FIRMWARE(IWL7260_UCODE_API_OK));
> -MODULE_FIRMWARE(IWL3160_MODULE_FIRMWARE(IWL3160_UCODE_API_OK));
> +MODULE_FIRMWARE(IWL3160_MODULE_FIRMWARE(IWL3165_UCODE_API_OK));
> 
But this is also wrong, it should be 7260, and there should be a
separate entry for 3165. I'll get a patch on the way to fix it.

johannes

  reply	other threads:[~2015-09-22  8:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-19 10:39 [PATCH] iwlwifi: fix requested firmware name for iwlwifi-3160 Hauke Mehrtens
2015-09-22  8:44 ` Johannes Berg [this message]
2015-09-22  8:46   ` Johannes Berg
2015-09-22 19:14     ` Hauke Mehrtens
2015-09-22 19:16       ` Johannes Berg
2015-10-05 12:18         ` Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442911476.2018.2.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=emmanuel.grumbach@intel.com \
    --cc=hauke@hauke-m.de \
    --cc=ilw@linux.intel.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.