From: sfeldma@gmail.com
To: netdev@vger.kernel.org
Cc: jiri@resnulli.us, siva.mannem.lnx@gmail.com,
pjonnala@broadcom.com, stephen@networkplumber.org,
roopa@cumulusnetworks.com, andrew@lunn.ch, f.fainelli@gmail.com,
vivien.didelot@savoirfairelinux.com
Subject: [PATCH net-next 2/4] switchdev: skip over ports returning -EOPNOTSUPP when recursing ports
Date: Thu, 24 Sep 2015 13:59:28 -0700 [thread overview]
Message-ID: <1443128370-27353-3-git-send-email-sfeldma@gmail.com> (raw)
In-Reply-To: <1443128370-27353-1-git-send-email-sfeldma@gmail.com>
From: Scott Feldman <sfeldma@gmail.com>
This allows us to recurse over all the ports, skipping over unsupporting
ports. Without the change, the recursion would stop at first unsupported
port.
Signed-off-by: Scott Feldman <sfeldma@gmail.com>
---
include/net/switchdev.h | 1 +
net/switchdev/switchdev.c | 9 ++++++++-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/include/net/switchdev.h b/include/net/switchdev.h
index 54b2faa..22a6dbe 100644
--- a/include/net/switchdev.h
+++ b/include/net/switchdev.h
@@ -15,6 +15,7 @@
#include <linux/notifier.h>
#define SWITCHDEV_F_NO_RECURSE BIT(0)
+#define SWITCHDEV_F_SKIP_EOPNOTSUPP BIT(1)
enum switchdev_trans {
SWITCHDEV_TRANS_NONE,
diff --git a/net/switchdev/switchdev.c b/net/switchdev/switchdev.c
index fda38f8..5c30da0 100644
--- a/net/switchdev/switchdev.c
+++ b/net/switchdev/switchdev.c
@@ -73,7 +73,7 @@ static int __switchdev_port_attr_set(struct net_device *dev,
return ops->switchdev_port_attr_set(dev, attr);
if (attr->flags & SWITCHDEV_F_NO_RECURSE)
- return err;
+ goto done;
/* Switch device port(s) may be stacked under
* bond/team/vlan dev, so recurse down to set attr on
@@ -82,10 +82,17 @@ static int __switchdev_port_attr_set(struct net_device *dev,
netdev_for_each_lower_dev(dev, lower_dev, iter) {
err = __switchdev_port_attr_set(lower_dev, attr);
+ if (err == -EOPNOTSUPP &&
+ attr->flags & SWITCHDEV_F_SKIP_EOPNOTSUPP)
+ continue;
if (err)
break;
}
+done:
+ if (err == -EOPNOTSUPP && attr->flags & SWITCHDEV_F_SKIP_EOPNOTSUPP)
+ err = 0;
+
return err;
}
--
1.7.10.4
next prev parent reply other threads:[~2015-09-24 20:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 20:59 [PATCH net-next 0/4] switchdev: push bridge attributes down sfeldma
2015-09-24 20:59 ` [PATCH net-next 1/4] switchdev: add bridge attributes sfeldma
2015-09-25 4:32 ` Premkumar Jonnala
2015-09-25 5:51 ` David Miller
2015-09-24 20:59 ` sfeldma [this message]
2015-09-25 4:33 ` [PATCH net-next 2/4] switchdev: skip over ports returning -EOPNOTSUPP when recursing ports Premkumar Jonnala
2015-09-24 20:59 ` [PATCH net-next 3/4] bridge: push bridge setting ageing_time down to switchdev sfeldma
2015-09-24 20:59 ` [PATCH net-next 4/4] rocker: handle setting bridge ageing_time sfeldma
2015-09-24 21:05 ` [PATCH net-next 0/4] switchdev: push bridge attributes down Stephen Hemminger
2015-09-25 3:25 ` Scott Feldman
2015-09-25 3:47 ` Stephen Hemminger
2015-09-25 1:23 ` Florian Fainelli
2015-09-25 1:53 ` Andrew Lunn
2015-09-25 4:26 ` Scott Feldman
2015-09-29 5:22 ` Florian Fainelli
2015-09-29 5:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443128370-27353-3-git-send-email-sfeldma@gmail.com \
--to=sfeldma@gmail.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pjonnala@broadcom.com \
--cc=roopa@cumulusnetworks.com \
--cc=siva.mannem.lnx@gmail.com \
--cc=stephen@networkplumber.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.