From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0120.outbound.protection.outlook.com [65.55.169.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 2C3D61A0145 for ; Fri, 25 Sep 2015 12:44:07 +1000 (AEST) Message-ID: <1443149032.32298.102.camel@freescale.com> Subject: Re: [PATCH v3 1/2] fsl: Add binding for RCPM From: Scott Wood To: Wang Dongsheng-B40534 CC: "robh+dt@kernel.org" , "shawnguo@kernel.org" , Jin Zhengxiong-R64188 , "Wang Huan-B18965" , "devicetree@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , Zhao Chenhui-B35336 , Tang Yuantian-B29983 Date: Thu, 24 Sep 2015 21:43:52 -0500 In-Reply-To: References: <1443083354-37369-1-git-send-email-dongsheng.wang@freescale.com> <1443123009.32298.29.camel@freescale.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2015-09-24 at 21:38 -0500, Wang Dongsheng-B40534 wrote: > > > +* Freescale RCPM Wakeup Source Device Tree Bindings > > > +------------------------------------------- > > > +Required rcpm-wakeup property should be added to a device node if the > > > device > > > +can be used as a wakeup source. > > > + > > > + - rcpm-wakeup: The value of the property consists of cells, the > > > number of > > > + cells defined in "fsl,#rcpm-wakeup-cells". The first cell is a > > > pointer > > > + to the rcpm node, the second cell is the bit mask that should be > > > set > > > + in IPPDEXPCR0, and the third cell is for IPPDEXPCR1, and so on. > > > > The phandle should not be included in the cell count. > > > > Yes, the first cell "&rcpm" should be in the cell count, right? No. None of the other #foo-cells work that way. -Scott From mboxrd@z Thu Jan 1 00:00:00 1970 From: scottwood@freescale.com (Scott Wood) Date: Thu, 24 Sep 2015 21:43:52 -0500 Subject: [PATCH v3 1/2] fsl: Add binding for RCPM In-Reply-To: References: <1443083354-37369-1-git-send-email-dongsheng.wang@freescale.com> <1443123009.32298.29.camel@freescale.com> Message-ID: <1443149032.32298.102.camel@freescale.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 2015-09-24 at 21:38 -0500, Wang Dongsheng-B40534 wrote: > > > +* Freescale RCPM Wakeup Source Device Tree Bindings > > > +------------------------------------------- > > > +Required rcpm-wakeup property should be added to a device node if the > > > device > > > +can be used as a wakeup source. > > > + > > > + - rcpm-wakeup: The value of the property consists of cells, the > > > number of > > > + cells defined in "fsl,#rcpm-wakeup-cells". The first cell is a > > > pointer > > > + to the rcpm node, the second cell is the bit mask that should be > > > set > > > + in IPPDEXPCR0, and the third cell is for IPPDEXPCR1, and so on. > > > > The phandle should not be included in the cell count. > > > > Yes, the first cell "&rcpm" should be in the cell count, right? No. None of the other #foo-cells work that way. -Scott From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Wood Subject: Re: [PATCH v3 1/2] fsl: Add binding for RCPM Date: Thu, 24 Sep 2015 21:43:52 -0500 Message-ID: <1443149032.32298.102.camel@freescale.com> References: <1443083354-37369-1-git-send-email-dongsheng.wang@freescale.com> <1443123009.32298.29.camel@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wang Dongsheng-B40534 Cc: "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , Jin Zhengxiong-R64188 , Wang Huan-B18965 , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Zhao Chenhui-B35336 , Tang Yuantian-B29983 List-Id: devicetree@vger.kernel.org On Thu, 2015-09-24 at 21:38 -0500, Wang Dongsheng-B40534 wrote: > > > +* Freescale RCPM Wakeup Source Device Tree Bindings > > > +------------------------------------------- > > > +Required rcpm-wakeup property should be added to a device node if the > > > device > > > +can be used as a wakeup source. > > > + > > > + - rcpm-wakeup: The value of the property consists of cells, the > > > number of > > > + cells defined in "fsl,#rcpm-wakeup-cells". The first cell is a > > > pointer > > > + to the rcpm node, the second cell is the bit mask that should be > > > set > > > + in IPPDEXPCR0, and the third cell is for IPPDEXPCR1, and so on. > > > > The phandle should not be included in the cell count. > > > > Yes, the first cell "&rcpm" should be in the cell count, right? No. None of the other #foo-cells work that way. -Scott -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html