From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: Re: [PATCH cgroup/for-4.3-fixes] cgroup, writeback: don't enable cgroup writeback on traditional hierarchies Date: Fri, 25 Sep 2015 09:49:09 +0300 Message-ID: <1443163749.19983.254.camel@gmail.com> References: <1434495193-31182-1-git-send-email-tj@kernel.org> <1434495193-31182-3-git-send-email-tj@kernel.org> <20150722035620.GD2944@thunk.org> <1443012552.19983.209.camel@gmail.com> <20150923180934.GE26647@mtj.duckdns.org> <20150923185137.GJ26647@mtj.duckdns.org> <20150923210729.GA23180@mtj.duckdns.org> <1443082186.19983.234.camel@gmail.com> <20150924204529.GF25415@mtj.duckdns.org> Reply-To: dedekind1@gmail.com Mime-Version: 1.0 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20150924204529.GF25415@mtj.duckdns.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="utf-8" To: Tejun Heo Cc: Theodore Ts'o , axboe@kernel.dk, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, lizefan@huawei.com, cgroups@vger.kernel.org, hannes@cmpxchg.org, kernel-team@fb.com, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, Dexuan Cui On Thu, 2015-09-24 at 16:45 -0400, Tejun Heo wrote: > Hello, Artem. >=20 > On Thu, Sep 24, 2015 at 11:09:46AM +0300, Artem Bityutskiy wrote: > > On Wed, 2015-09-23 at 17:07 -0400, Tejun Heo wrote: > > > So, this should make the regression go away. It doesn't fix the > > > underlying bugs but they shouldn't get triggered by people not > > > experimenting with cgroup. > >=20 > > this hits the nail on the head and makes the problem go away. >=20 > Yeah but there still is an underlying problem here. I've been going > through the sync path today but can't trigger or spot anything wrong. > Can you please apply the patch at the end of this mail, trigger the > failure and report the kernel log? >=20 > Thanks a lot. Does not compile with multiple errors like linux/fs/fs-writeback.c:799:10: error: =E2=80=98struct bdi_writeback=E2= =80=99 has no member named =E2=80=98last_comp_gen=E2=80=99 bdi->wb.last_comp_gen =3D bdi->wb.comp_gen; ^ -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755272AbbIYGtU (ORCPT ); Fri, 25 Sep 2015 02:49:20 -0400 Received: from mga14.intel.com ([192.55.52.115]:57874 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754275AbbIYGtO (ORCPT ); Fri, 25 Sep 2015 02:49:14 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,585,1437462000"; d="scan'208";a="652002226" Message-ID: <1443163749.19983.254.camel@gmail.com> Subject: Re: [PATCH cgroup/for-4.3-fixes] cgroup, writeback: don't enable cgroup writeback on traditional hierarchies From: Artem Bityutskiy Reply-To: dedekind1@gmail.com To: Tejun Heo Cc: "Theodore Ts'o" , axboe@kernel.dk, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, lizefan@huawei.com, cgroups@vger.kernel.org, hannes@cmpxchg.org, kernel-team@fb.com, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, Dexuan Cui Date: Fri, 25 Sep 2015 09:49:09 +0300 In-Reply-To: <20150924204529.GF25415@mtj.duckdns.org> References: <1434495193-31182-1-git-send-email-tj@kernel.org> <1434495193-31182-3-git-send-email-tj@kernel.org> <20150722035620.GD2944@thunk.org> <1443012552.19983.209.camel@gmail.com> <20150923180934.GE26647@mtj.duckdns.org> <20150923185137.GJ26647@mtj.duckdns.org> <20150923210729.GA23180@mtj.duckdns.org> <1443082186.19983.234.camel@gmail.com> <20150924204529.GF25415@mtj.duckdns.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 (3.16.5-1.fc22) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-09-24 at 16:45 -0400, Tejun Heo wrote: > Hello, Artem. > > On Thu, Sep 24, 2015 at 11:09:46AM +0300, Artem Bityutskiy wrote: > > On Wed, 2015-09-23 at 17:07 -0400, Tejun Heo wrote: > > > So, this should make the regression go away. It doesn't fix the > > > underlying bugs but they shouldn't get triggered by people not > > > experimenting with cgroup. > > > > this hits the nail on the head and makes the problem go away. > > Yeah but there still is an underlying problem here. I've been going > through the sync path today but can't trigger or spot anything wrong. > Can you please apply the patch at the end of this mail, trigger the > failure and report the kernel log? > > Thanks a lot. Does not compile with multiple errors like linux/fs/fs-writeback.c:799:10: error: ‘struct bdi_writeback’ has no member named ‘last_comp_gen’ bdi->wb.last_comp_gen = bdi->wb.comp_gen; ^