From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45706)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <prvs=703e89765=Ian.Campbell@citrix.com>)
	id 1ZfV4t-0007V5-I8
	for qemu-devel@nongnu.org; Fri, 25 Sep 2015 11:38:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <prvs=703e89765=Ian.Campbell@citrix.com>)
	id 1ZfV4q-0006AZ-BZ
	for qemu-devel@nongnu.org; Fri, 25 Sep 2015 11:38:27 -0400
Received: from smtp02.citrix.com ([66.165.176.63]:30925)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <prvs=703e89765=Ian.Campbell@citrix.com>)
	id 1ZfV4q-0006AI-85
	for qemu-devel@nongnu.org; Fri, 25 Sep 2015 11:38:24 -0400
Message-ID: <1443195500.25250.167.camel@citrix.com>
From: Ian Campbell <ian.campbell@citrix.com>
Date: Fri, 25 Sep 2015 16:38:20 +0100
In-Reply-To: <1442565017-31725-3-git-send-email-tiejun.chen@intel.com>
References: <1442565017-31725-1-git-send-email-tiejun.chen@intel.com>
	<1442565017-31725-3-git-send-email-tiejun.chen@intel.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [v4][PATCH 2/2] libxl: introduce gfx_passthru_kind
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tiejun Chen <tiejun.chen@intel.com>, wei.liu2@citrix.com, stefano.stabellini@citrix.com, Ian.Jackson@eu.citrix.com
Cc: qemu-devel@nongnu.org, xen-devel@lists.xen.org

On Fri, 2015-09-18 at 16:30 +0800, Tiejun Chen wrote:
> Although we already have 'gfx_passthru' in b_info, this doesn't suffice
> after we want to handle IGD specifically. Now we define a new field of
> type, gfx_passthru_kind, to indicate we're trying to pass IGD. Actually
> this means we can benefit this to support other specific devices just
> by extending gfx_passthru_kind. And then we can cooperate with
> gfx_passthru to address IGD cases as follows:
> 
>     gfx_passthru = 0    => sets build_info.u.gfx_passthru to false
>     gfx_passthru = 1    => sets build_info.u.gfx_passthru to true and
>                            build_info.u.gfx_passthru_kind to DEFAULT
>     gfx_passthru = "igd"    => sets build_info.u.gfx_passthru to true
>                                and build_info.u.gfx_passthru_kind to IGD
> 
> Here if gfx_passthru_kind = DEFAULT, we will call
> libxl__is_igd_vga_passthru() to check if we're hitting that table to need
> to pass that option to qemu. But if gfx_passthru_kind = "igd" we always
> force to pass that.
> 
> And "-gfx_passthru" is just introduced to work for qemu-xen-traditional
> so we should get this away from libxl__build_device_model_args_new() in
> the case of qemu upstream.
> 
> Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>

Acked + applied both patches, thanks.

Stefano -- are the QEMU side patches in qemu-upstream-unstable.git yet? If
not I suppose this is a call/reminder to backport them from mainline or
whatever.

Ian.