From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 1/8] xen/arm: gic: Make clear the GIC node is passed to make_hwdom_dt_node Date: Fri, 25 Sep 2015 16:48:18 +0100 Message-ID: <1443196098.25250.174.camel@citrix.com> References: <1442944062-4324-1-git-send-email-julien.grall@citrix.com> <1442944062-4324-2-git-send-email-julien.grall@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZfVEU-0000h0-91 for xen-devel@lists.xenproject.org; Fri, 25 Sep 2015 15:48:22 +0000 In-Reply-To: <1442944062-4324-2-git-send-email-julien.grall@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall , xen-devel@lists.xenproject.org Cc: stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On Tue, 2015-09-22 at 18:47 +0100, Julien Grall wrote: "Make it clear..." in the subject. > The callback make_hwdom_dt_node already have the gic node in parameter. "...already has the..." or "...already takes the..." > Rather than using a weird mix between "dt_interrupt_controller" (aliased > to "gic") and "node", rename the callback parameter "node" to "gic". "... and remove local gic definitions in terms of the global dt_interrupt_controller". Also given the hunk below I'd recommend adding: "Add an assert to gic_make_hwdom_dt_node to check that the gic really is the global dt_interrupt_controller" > @@ -702,10 +702,12 @@ void __cpuinit init_maintenance_interrupt(void) > } > > int gic_make_hwdom_dt_node(const struct domain *d, > - const struct dt_device_node *node, > + const struct dt_device_node *gic, > void *fdt) > { > - return gic_hw_ops->make_hwdom_dt_node(d, node, fdt); > + ASSERT(gic == dt_interrupt_controller); > + > + return gic_hw_ops->make_hwdom_dt_node(d, gic, fdt); > } With those commit message changes: Acked-by: Ian Campbell