From: Ian Campbell <ian.campbell@citrix.com>
To: Julien Grall <julien.grall@citrix.com>, xen-devel@lists.xenproject.org
Cc: stefano.stabellini@citrix.com
Subject: Re: [PATCH 3/8] xen/arm: Fix comment coding style in handle_node in domain_build.c
Date: Fri, 25 Sep 2015 17:48:33 +0100 [thread overview]
Message-ID: <1443199713.25250.216.camel@citrix.com> (raw)
In-Reply-To: <1442944062-4324-4-git-send-email-julien.grall@citrix.com>
On Tue, 2015-09-22 at 18:47 +0100, Julien Grall wrote:
> Only coding style changes. No functional changes.
>
> Signed-off-by: Julien Grall <julien.grall@citrix.com>
Acked + applied since it was obvious.
> ---
> xen/arch/arm/domain_build.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
> index f7ea240..651d75e 100644
> --- a/xen/arch/arm/domain_build.c
> +++ b/xen/arch/arm/domain_build.c
> @@ -1226,8 +1226,10 @@ static int handle_node(struct domain *d, struct
> kernel_info *kinfo,
> return 0;
> }
>
> - /* Replace these nodes with our own. Note that the original may be
> - * used_by DOMID_XEN so this check comes first. */
> + /*
> + * Replace these nodes with our own. Note that the original may be
> + * used_by DOMID_XEN so this check comes first.
> + */
> if ( device_get_class(node) == DEVICE_GIC )
> return make_gic_node(d, kinfo->fdt, node);
> if ( dt_match_node(timer_matches, node) )
> @@ -1240,7 +1242,8 @@ static int handle_node(struct domain *d, struct
> kernel_info *kinfo,
> return 0;
> }
>
> - /* Even if the IOMMU device is not used by Xen, it should not be
> + /*
> + * Even if the IOMMU device is not used by Xen, it should not be
> * passthrough to DOM0
> */
> if ( device_get_class(node) == DEVICE_IOMMU )
next prev parent reply other threads:[~2015-09-25 16:48 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 17:47 [PATCH 0/8] xen/arm: gic-v2: Detect automatically aliased GIC400 Julien Grall
2015-09-22 17:47 ` [PATCH 1/8] xen/arm: gic: Make clear the GIC node is passed to make_hwdom_dt_node Julien Grall
2015-09-25 15:48 ` Ian Campbell
2015-09-28 14:49 ` Julien Grall
2015-09-22 17:47 ` [PATCH 2/8] xen/arm: Retrieve the correct number of cells when building dom0 DT Julien Grall
2015-09-25 16:01 ` Ian Campbell
2015-09-28 14:59 ` Julien Grall
2015-09-28 15:19 ` Ian Campbell
2015-09-28 15:25 ` Julien Grall
2015-09-22 17:47 ` [PATCH 3/8] xen/arm: Fix comment coding style in handle_node in domain_build.c Julien Grall
2015-09-25 16:03 ` Ian Campbell
2015-09-25 16:48 ` Ian Campbell [this message]
2015-09-22 17:47 ` [PATCH 4/8] xen/arm: Warn when a device tree path will be re-used by Xen Julien Grall
2015-09-25 16:10 ` Ian Campbell
2015-09-28 15:44 ` Julien Grall
2015-09-28 15:55 ` Ian Campbell
2015-09-28 16:05 ` Julien Grall
2015-09-28 17:46 ` Julien Grall
2015-09-22 17:47 ` [PATCH 5/8] xen/arm: vgic-v2: Drop cbase from arch_domain Julien Grall
2015-09-25 16:11 ` Ian Campbell
2015-09-22 17:47 ` [PATCH 6/8] xen/arm: gic: Check the size of the CPU and vCPU interface retrieved from DT Julien Grall
2015-09-25 16:19 ` Ian Campbell
2015-09-28 16:29 ` Julien Grall
2015-09-22 17:47 ` [PATCH 7/8] xen/arm: gic-v2: Detect automatically aliased GIC400 Julien Grall
2015-09-25 16:26 ` Ian Campbell
2015-09-28 18:07 ` Julien Grall
2015-09-29 10:51 ` Ian Campbell
2015-09-22 17:47 ` [PATCH 8/8] xen/arm: platform: Drop the quirks callback Julien Grall
2015-09-25 16:27 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443199713.25250.216.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=julien.grall@citrix.com \
--cc=stefano.stabellini@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.