All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Franco <alejandro.franco@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Cc: randy.e.witt@intel.com
Subject: [PATCH] AB random failure: libpcre-native split_and_strip
Date: Fri, 25 Sep 2015 17:54:11 -0500	[thread overview]
Message-ID: <1443221651-7364-1-git-send-email-alejandro.franco@linux.intel.com> (raw)

Error handling: adding file-native as a dependency to libpre recipe
should guarantee a consistent, and more importantly POSIX-compliant
version of the "file" command is always used when checking the file
"pcre-config" within the isELF function in staging.bbclass.

Following the POSIX behavior, file returns 0 and continues, when an
error is found while checking a file.

Debug: in cases where file may still fail, the resulting error will
now be logged along with the split_and_strip_files failure.

[YOCTO #8144]

Signed-off-by: Alex Franco <alejandro.franco@linux.intel.com>
---
 meta/classes/staging.bbclass                 | 2 +-
 meta/recipes-support/libpcre/libpcre_8.37.bb | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/classes/staging.bbclass b/meta/classes/staging.bbclass
index 967eddd..554c2e4 100644
--- a/meta/classes/staging.bbclass
+++ b/meta/classes/staging.bbclass
@@ -77,7 +77,7 @@ python sysroot_strip () {
         ret, result = oe.utils.getstatusoutput("file \"%s\"" % path.replace("\"", "\\\""))
 
         if ret:
-            bb.error("split_and_strip_files: 'file %s' failed" % path)
+            bb.error("split_and_strip_files: 'file %s' failed\nError: %s" % (path, result))
             return type
 
         # Not stripped
diff --git a/meta/recipes-support/libpcre/libpcre_8.37.bb b/meta/recipes-support/libpcre/libpcre_8.37.bb
index bcfc9e9..1a2024d 100644
--- a/meta/recipes-support/libpcre/libpcre_8.37.bb
+++ b/meta/recipes-support/libpcre/libpcre_8.37.bb
@@ -20,7 +20,7 @@ SRC_URI[sha256sum] = "51679ea8006ce31379fb0860e46dd86665d864b5020fc9cd19e71260ee
 S = "${WORKDIR}/pcre-${PV}"
 
 PROVIDES += "pcre"
-DEPENDS += "bzip2 zlib"
+DEPENDS += "bzip2 zlib file-native"
 
 PACKAGECONFIG[pcretest-readline] = "--enable-pcretest-libreadline,--disable-pcretest-libreadline,readline,"
 
-- 
2.5.3



             reply	other threads:[~2015-09-25 22:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-25 22:54 Alex Franco [this message]
2015-09-26  6:58 ` [PATCH] AB random failure: libpcre-native split_and_strip Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443221651-7364-1-git-send-email-alejandro.franco@linux.intel.com \
    --to=alejandro.franco@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=randy.e.witt@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.