From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH 1/2] i40e: Fix RS bit update in Tx path and disable force WB workaround
Date: Fri, 25 Sep 2015 16:18:25 -0700 [thread overview]
Message-ID: <1443223105.2987.48.camel@intel.com> (raw)
In-Reply-To: <1443207609-171288-1-git-send-email-anjali.singhai@intel.com>
On Fri, 2015-09-25 at 12:00 -0700, Anjali Singhai Jain wrote:
> This patch fixes the issue of forcing WB too often causing us to not
> benefit from NAPI.
>
> Without this patch we were forcing WB/arming interrupt too often
> taking
> away the benefits of NAPI and causing a performance impact.
>
> With this patch we disable force WB in the clean routine for X710
> and XL710 adapters. X722 adapters do not enable interrupt to force
> a WB and benefit from WB_ON_ITR and hence force WB is left enabled
> for those adapters.
> For XL710 and X710 adapters if we have less than 4 packets pending
> a software Interrupt triggered from service task will force a WB.
>
> This patch also changes the conditions for setting RS bit as
> described
> in code comments. This optimizes when the HW does a tail bump amd
> when
> it does a WB. It also optimizes when we do a wmb.
>
> Signed-off-by: Anjali Singhai Jain <anjali.singhai@intel.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_txrx.c | 126 ++++++++++++++++++
> ----------
> drivers/net/ethernet/intel/i40e/i40e_txrx.h | 2 +
> 2 files changed, 86 insertions(+), 42 deletions(-)
This applied with a little massaging, but seeing that the second patch
does not apply at all. I am dropping this patch.
Please resend an updated patch against my next-queue tree, dev-queue
branch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20150925/6a834ff5/attachment-0001.asc>
next prev parent reply other threads:[~2015-09-25 23:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 19:00 [Intel-wired-lan] [PATCH 1/2] i40e: Fix RS bit update in Tx path and disable force WB workaround Anjali Singhai Jain
2015-09-25 19:00 ` [Intel-wired-lan] [PATCH 2/2] i40e: Disable Check for Hang Anjali Singhai Jain
2015-09-25 23:16 ` Jeff Kirsher
2015-09-25 19:50 ` [Intel-wired-lan] [PATCH 1/2] i40e: Fix RS bit update in Tx path and disable force WB workaround Singhai, Anjali
2015-09-25 23:18 ` Jeff Kirsher [this message]
2015-09-26 0:00 ` Singhai, Anjali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443223105.2987.48.camel@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.