All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
To: <lee.jones@linaro.org>
Cc: <sameo@linux.intel.com>, <patches@opensource.wolfsonmicro.com>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH 6/6 RESEND] mfd: arizona: use correct type ID for device tree config
Date: Mon, 28 Sep 2015 13:46:46 +0100	[thread overview]
Message-ID: <1443444406-30518-7-git-send-email-rf@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1443444406-30518-1-git-send-email-rf@opensource.wolfsonmicro.com>

In the case of a device tree config the code uses the device ID
from the DT entry to check which codec is required but when storing
the ID into struct arizona it was always using the non-DT SPI device
table to get an ID.

This patch changes the code to store the correct ID into struct arizona.

Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
---
 drivers/mfd/arizona-i2c.c | 5 ++---
 drivers/mfd/arizona-spi.c | 5 ++---
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/mfd/arizona-i2c.c b/drivers/mfd/arizona-i2c.c
index 914bdce..4e3afd1 100644
--- a/drivers/mfd/arizona-i2c.c
+++ b/drivers/mfd/arizona-i2c.c
@@ -56,8 +56,7 @@ static int arizona_i2c_probe(struct i2c_client *i2c,
 			regmap_config = &wm8998_i2c_regmap;
 		break;
 	default:
-		dev_err(&i2c->dev, "Unknown device type %ld\n",
-			id->driver_data);
+		dev_err(&i2c->dev, "Unknown device type %ld\n", type);
 		return -EINVAL;
 	}
 
@@ -79,7 +78,7 @@ static int arizona_i2c_probe(struct i2c_client *i2c,
 		return ret;
 	}
 
-	arizona->type = id->driver_data;
+	arizona->type = type;
 	arizona->dev = &i2c->dev;
 	arizona->irq = i2c->irq;
 
diff --git a/drivers/mfd/arizona-spi.c b/drivers/mfd/arizona-spi.c
index 850a63a..8cffb1c 100644
--- a/drivers/mfd/arizona-spi.c
+++ b/drivers/mfd/arizona-spi.c
@@ -47,8 +47,7 @@ static int arizona_spi_probe(struct spi_device *spi)
 			regmap_config = &wm5110_spi_regmap;
 		break;
 	default:
-		dev_err(&spi->dev, "Unknown device type %ld\n",
-			id->driver_data);
+		dev_err(&spi->dev, "Unknown device type %ld\n", type);
 		return -EINVAL;
 	}
 
@@ -70,7 +69,7 @@ static int arizona_spi_probe(struct spi_device *spi)
 		return ret;
 	}
 
-	arizona->type = id->driver_data;
+	arizona->type = type;
 	arizona->dev = &spi->dev;
 	arizona->irq = spi->irq;
 
-- 
1.9.1


  parent reply	other threads:[~2015-09-28 12:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-28 12:46 [PATCH 0/6 RESEND] mfd: arizona: Various improvements and refactoring Richard Fitzgerald
2015-09-28 12:46 ` [PATCH 1/6 RESEND] mfd: arizona: factor out DCVDD isolation control Richard Fitzgerald
2015-09-28 12:46 ` [PATCH 2/6 RESEND] mfd: arizona: factor out checking of jack detection state Richard Fitzgerald
2015-09-28 12:46 ` [PATCH 3/6 RESEND] mfd: arizona: Downgrade type mismatch messages to dev_warn Richard Fitzgerald
2015-10-01 11:17   ` Lee Jones
2015-09-28 12:46 ` [PATCH 4/6 RESEND] mfd: arizona: Simplify adding subdevices Richard Fitzgerald
2015-10-01 11:41   ` Lee Jones
2015-09-28 12:46 ` [PATCH 5/6 RESEND] mfd: arizona: Remove use of codec build config #ifdefs Richard Fitzgerald
2015-10-01 11:44   ` Lee Jones
2015-10-02  9:23     ` Charles Keepax
2015-09-28 12:46 ` Richard Fitzgerald [this message]
2015-10-01 11:46   ` [PATCH 6/6 RESEND] mfd: arizona: use correct type ID for device tree config Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443444406-30518-7-git-send-email-rf@opensource.wolfsonmicro.com \
    --to=rf@opensource.wolfsonmicro.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.