All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Galbraith <umgwanakikbuti@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Darren Hart <dvhart@linux.intel.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [v4.2+ regression] fd7a4bed sched, rt: Convert switched_{from, to}_rt() / prio_changed_rt() to balance callbacks
Date: Tue, 29 Sep 2015 10:19:51 +0200	[thread overview]
Message-ID: <1443514791.5403.12.camel@gmail.com> (raw)
In-Reply-To: <1443406620.3293.26.camel@gmail.com>

On Mon, 2015-09-28 at 04:17 +0200, Mike Galbraith wrote:
> Hi Peter,
> 
> I bumped into an odd futextest regression, and finally bisected it to
> $subject.  I haven't poked at it yet, chasing down and confirming the
> little bugger munched the day.

homer:/home/git/futextest/functional # ./futex_requeue_pi -c -b -o -t 500000 -v 2 2>&1|egrep 'exit|Blocker'
         INFO: Waiter 0: exiting with 0
         INFO: Waiter 1: exiting with 0
         INFO: Waiter 2: exiting with 0
         INFO: Waiter 3: exiting with 0
         INFO: Waiter 4: exiting with 0
         INFO: Waiter 5: exiting with 0
         INFO: Waiter 6: exiting with 0
         INFO: Waiter 7: exiting with 0
         INFO: Waiter 8: exiting with 0
         INFO: Waiter 9: exiting with 0
         INFO: Waker: exiting with 0
         INFO: Blocker: Calling futex_wait()

Well now, it _seems_ you're innocent Peter.  Waker can call futex_wake()
before blocker calls futex_wait(), leaving poor blocker stranded.

Adding atomic_inc(&waiters_blocked) to blocker, and telling wakers to
expect one more when a blocker exists seems to have fixed it up.

	-Mike



  reply	other threads:[~2015-09-29  8:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-28  2:17 [v4.2+ regression] fd7a4bed sched, rt: Convert switched_{from, to}_rt() / prio_changed_rt() to balance callbacks Mike Galbraith
2015-09-29  8:19 ` Mike Galbraith [this message]
2015-09-29  8:55   ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443514791.5403.12.camel@gmail.com \
    --to=umgwanakikbuti@gmail.com \
    --cc=dvhart@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.