From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 13/13] tools/libxl: Add 'vtsc_khz' option to
 set guest TSC rate
Date: Tue, 29 Sep 2015 11:28:38 +0100
Message-ID: <1443522518.16718.36.camel@citrix.com>
References: <1443424438-13404-1-git-send-email-haozhong.zhang@intel.com>
	<1443424438-13404-14-git-send-email-haozhong.zhang@intel.com>
	<1443521054.16718.29.camel@citrix.com>
	<20150929101339.GC3789@hzzhang-OptiPlex-9020.sh.intel.com>
	<560A66E4.2010205@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <560A66E4.2010205@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>, xen-devel@lists.xen.org, Ian Jackson <ian.jackson@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, Keir
	Fraser <keir@xen.org>, Jan Beulich <jbeulich@suse.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>, Jun Nakajima <jun.nakajima@intel.com>, Kevin Tian <kevin.tian@intel.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-09-29 at 11:24 +0100, Andrew Cooper wrote:
> On 29/09/15 11:13, Haozhong Zhang wrote:
> > On Tue, Sep 29, 2015 at 11:04:14AM +0100, Ian Campbell wrote:
> > > On Mon, 2015-09-28 at 15:13 +0800, Haozhong Zhang wrote:
> > > > This patch adds an option 'vtsc_khz' to allow users to set vcpu's
> > > > TSC
> > > > rate in KHz. In the case that tsc_mode = 'default', the default
> > > > value of
> > > > 'vtsc_khz' option is the host TSC rate which is used when
> > > > 'vtsc_khz'
> > > > option is set to 0 or does not appear in the configuration. In all
> > > > other
> > > > cases of tsc_mode, 'vtsc_khz' option is just ignored.
> > > > 
> > > > Another purpose of adding this option is to keep vcpu's TSC rate
> > > > across
> > > > guest reboot. In existing code, a new domain is created from the
> > > > configuration of the previous domain which was just rebooted.
> > > > vcpu's TSC
> > > > rate is not stored in the configuration and the host TSC rate is
> > > > the
> > > > used as vcpu's TSC rate. This works fine unless the previous domain
> > > > was
> > > > migrated from another host machine with a different host TSC rate
> > > > than
> > > > the current one.
> > > I understand why this is necessary over a migration, but why is it
> > > important to be able to retain the TSC rate across a reboot? What is
> > > the
> > > usecase there?
> > > 
> > No usecase so far. Is 'making a virtual machine more like a physical
> > machine' reasonable here? (I suppose a physical machine retains TSC
> > rate across reboot)
> 
> There are situations such as altering firmware settings which can cause
> the TSC rate to differ across reboot.  I don't see any reason to try and
> maintain it across VM reboots.

Right. If it happens to come for free as a side effect of making it work
for migration then fine.

But it seems to me that tsc rate could/should be in the hypervisors save
blob and require no interaction with the toolstack once it is latched when
the domain is built.

Ian.