From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 7/8] xen/arm: gic-v2: Detect automatically aliased GIC400 Date: Tue, 29 Sep 2015 11:51:06 +0100 Message-ID: <1443523866.16718.38.camel@citrix.com> References: <1442944062-4324-1-git-send-email-julien.grall@citrix.com> <1442944062-4324-8-git-send-email-julien.grall@citrix.com> <1443198416.25250.200.camel@citrix.com> <560981E8.4080200@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZgsV4-0004Bu-9L for xen-devel@lists.xenproject.org; Tue, 29 Sep 2015 10:51:10 +0000 In-Reply-To: <560981E8.4080200@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall , xen-devel@lists.xenproject.org Cc: stefano.stabellini@citrix.com, Zoltan Kiss List-Id: xen-devel@lists.xenproject.org On Mon, 2015-09-28 at 19:07 +0100, Julien Grall wrote: > On 25/09/15 17:26, Ian Campbell wrote: > > On Tue, 2015-09-22 at 18:47 +0100, Julien Grall wrote: > > > + gicv2.map_cbase = ioremap_nocache(cbase, csize); > > > + if ( !gicv2.map_cbase ) > > > panic("GICv2: Failed to ioremap for GIC CPU interface\n"); > > > > s/for/the/ or just s/for //. > > That's not part of my changes and the error is the same on every error > message after ioremap within the GIC* drivers. Oh sorry, my eye must have skipped a line as I scanned from the + > I won't change this one here, but if you really want I can send a > follow-up to fix it. No pressing need.