From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v1 2/8] xen/arm: io: Extend write/read
 handler to pass the register in parameter
Date: Tue, 29 Sep 2015 11:51:50 +0100
Message-ID: <1443523910.16718.39.camel@citrix.com>
References: <1443192698-16163-1-git-send-email-julien.grall@citrix.com>
	<1443192698-16163-3-git-send-email-julien.grall@citrix.com>
	<1443198971.25250.205.camel@citrix.com> <56096C64.9040306@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=7074e5ba0=Ian.Campbell@citrix.com>)
	id 1ZgsVo-0004IC-EQ
	for xen-devel@lists.xenproject.org; Tue, 29 Sep 2015 10:51:56 +0000
In-Reply-To: <56096C64.9040306@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@citrix.com>, xen-devel@lists.xenproject.org
Cc: Vijaya.Kumar@caviumnetworks.com, Julien Grall <julien.grall@linaro.org>, stefano.stabellini@citrix.com, manish.jaggi@caviumnetworks.com, vijay.kilari@gmail.com
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-09-28 at 17:35 +0100, Julien Grall wrote:
> Hi Ian,
> 
> On 25/09/15 17:36, Ian Campbell wrote:
> > On Fri, 2015-09-25 at 15:51 +0100, Julien Grall wrote:
> > > From: Julien Grall <julien.grall@linaro.org>
> > > 
> > > Rather than letting each handler to retrieve the register used by the
> > > I/O access, add a new parameter to pass the register in parameter.
> > > 
> > > This will help to implement generic register manipulation on I/O
> > > access
> > > such as sign-extension and endianess.
> > > 
> > > Read handlers need to modify the value of the register, so a pointer
> > > to
> > > it is given in argument. Write handlers shouldn't modify the
> > > register,
> > > therfore only a plain value is given.
> > 
> > "therefore"
> > > 
> > > Signed-off-by: Julien Grall <julien.grall@citrix.com>
> > 
> > Acked-by: Ian Campbell <ian.campbell@citrix.com.
> > 
> > Is it the case that read handlers today only update *r on success? 
> 
> Yes, each read handler only update the register mentioned in dabt.reg.

I meant that they do not touch it on failure.

> > Is that
> > a useful thing to mandate and/or enforce?
> 
> What do you mean?
> 
> Regards,
>