All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Lieven <pl@kamp.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V2] vnc: destroy server surface if no client is connected
Date: Tue, 29 Sep 2015 14:49:55 +0200	[thread overview]
Message-ID: <1443530995.21557.24.camel@redhat.com> (raw)
In-Reply-To: <CC45B647-7488-4501-BB97-BE10E1295A22@kamp.de>

On Di, 2015-09-29 at 14:41 +0200, Peter Lieven wrote:
> > Am 29.09.2015 um 12:28 schrieb Gerd Hoffmann <kraxel@redhat.com>:
> > 
> >  Hi,
> > 
> >> -    graphic_hw_update(vd->dcl.con);
> >> +    if (first_client) {
> >> +        /* set/restore the correct surface in the VNC server */
> >> +        console_select(0);
> > 
> > Nah, that has unwanted side effects.
> 
> okay, ill try to respin without this hack.
> 
> > 
> > Pushed some patches to git://git.kraxel.org/qemu rebase/ui-vnc-next,
> > could you have a look?
> 
> if you mean the RFC patches on the list I already send a bunch of comments on them.

It's updated, taking your comments in account, reworking the server
surface code so we can free it without clients, also added
qio_buffer_shrink() but added no calls yet.

cheers,
  Gerd

  reply	other threads:[~2015-09-29 12:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-25 18:36 [Qemu-devel] [PATCH V2] vnc: destroy server surface if no client is connected Peter Lieven
2015-09-29 10:28 ` Gerd Hoffmann
2015-09-29 12:41   ` Peter Lieven
2015-09-29 12:49     ` Gerd Hoffmann [this message]
2015-09-29 13:31       ` Peter Lieven
2015-09-29 14:08         ` Gerd Hoffmann
2015-09-29 14:36           ` Peter Lieven
2015-10-01  9:52           ` Peter Lieven
2015-10-02  7:36             ` Gerd Hoffmann
2015-10-02  8:03               ` Peter Lieven
2015-10-02  8:17                 ` Gerd Hoffmann
2015-10-05 15:14               ` Peter Lieven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443530995.21557.24.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=pl@kamp.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.