From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v7 2/2] xen/arm: support gzip compressed kernels Date: Tue, 29 Sep 2015 15:05:39 +0100 Message-ID: <1443535539.16718.89.camel@citrix.com> References: <1443033075-15573-2-git-send-email-stefano.stabellini@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1443033075-15573-2-git-send-email-stefano.stabellini@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Stefano Stabellini , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Wed, 2015-09-23 at 19:31 +0100, Stefano Stabellini wrote: > [/...] > + > + /* > + * Need to free pages after output_size here because they won't be > + * freed by discard_initial_modules > + */ > + i = (output_size + PAGE_SIZE - 1) >> PAGE_SHIFT; You have access to DIV_ROUND_UP here. The rest looks good to me. I'd have preferred to avoid exporting dt_unreserved_regions, but nevermind. Ian.