From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH OSSTEST 3/6] Debian: uboot: Use di_vg_name()
 and lv_dev_mapper() for root=
Date: Tue, 29 Sep 2015 15:18:26 +0100
Message-ID: <1443536306.16718.100.camel@citrix.com>
References: <1443519883.16718.23.camel@citrix.com>
	<1443519898-24444-3-git-send-email-ian.campbell@citrix.com>
	<22026.39774.25719.463467@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <22026.39774.25719.463467@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-09-29 at 15:08 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST 3/6] Debian: uboot: Use di_vg_name()
> and lv_dev_mapper() for root="):
> > root is not a "guest lv", so using target_guest_lv_name is misleading.
> > 
> > target_guest_lv_name also fails to properly handle the guest vg name
> > correctly, which di_vg_name does.
> 
> WDYM `the guest vg name' ?  If it's not a guest lv then is it a guest
> vg ?

Sorry, I think I meant "the d-i vg name". Specifically the default VG name
created by D-I changed in Jessie to append "-vg" to the hostname.

i.e. under Squeeze and Wheezy a machine foo would end up with /dev/foo/root
while under Jessie it becomes /dev/foo-vg/root.

>   Sorry if I am simply confused.

I think I said something unhelpfully confusing and wrong.

Ian.