From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v7 2/2] xen/arm: support gzip compressed
	kernels
Date: Tue, 29 Sep 2015 15:58:35 +0100
Message-ID: <1443538715.16718.112.camel@citrix.com>
References: <alpine.DEB.2.02.1509231927360.2672@kaball.uk.xensource.com>
	<1443033075-15573-2-git-send-email-stefano.stabellini@eu.citrix.com>
	<1443535539.16718.89.camel@citrix.com>
	<alpine.DEB.2.02.1509291545590.16775@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1509291545590.16775@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-09-29 at 15:46 +0100, Stefano Stabellini wrote:
> On Tue, 29 Sep 2015, Ian Campbell wrote:
> > On Wed, 2015-09-23 at 19:31 +0100, Stefano Stabellini wrote:
> > > [/...]
> > > +
> > > +    /* 
> > > +     * Need to free pages after output_size here because they won't
> > > be
> > > +     * freed by discard_initial_modules
> > > +     */
> > > +    i = (output_size + PAGE_SIZE - 1) >> PAGE_SHIFT;
> > 
> > You have access to DIV_ROUND_UP here.
> > 
> > The rest looks good to me.
> 
> Are you sure you want to introduce a / operation that can be easily
> avoided?

Given a divisor of PAGE_SIZE the compiler will turn it into a shift anyway.

Ian.