From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH OSSTEST v3 1/3] ts-openstack-deploy: Deploy
 OpenStack on a host with devstack
Date: Tue, 29 Sep 2015 16:34:44 +0100
Message-ID: <1443540884.16718.115.camel@citrix.com>
References: <1443455775-26131-1-git-send-email-anthony.perard@citrix.com>
	<1443455775-26131-2-git-send-email-anthony.perard@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1443455775-26131-2-git-send-email-anthony.perard@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xen.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-09-28 at 16:56 +0100, Anthony PERARD wrote:
> This script installs any necessary packages and clones all of the
> OpenStack
> trees which are used by devstack to deploy OpenStack.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

This mostly looks good to me. A few comments.

> +  # libvirt is already installed, but not as a package, so avoid
> installation of
> +  # the libvirt package with devstack
> +  target_editfile($ho, "$builddir/devstack/files/debs/nova", sub {
> +      while (<EI>) {
> +        next if m/.*libvirt.*/;
> +        print EO or die $!;
> +      }
> +  });
> +  target_editfile($ho, "$builddir/devstack/lib/nova_plugins/functions
> -libvirt", sub {
> +      while (<EI>) {
> +        next if m/install_package.*libvirt.*/;
> +        print EO or die $!;
> +      }
> +  });

Do these end up causing the built_revision_foo to say "-dirty" or anything
like that?

Maybe not because I don't see any calls to store_vcs_revision, which I
think we discussed on an earlier revision?

> +  # OpenStack needs access to libvirt from a user.
> +  target_cmd_root($ho, <<END);

You could use target_putfilecontents_root_stash for this too I think?

Ian.