From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH OSSTEST v3 2/3] ts-openstack-tempest: Run
 Tempest to check OpenStack
Date: Tue, 29 Sep 2015 16:43:50 +0100
Message-ID: <1443541430.16718.121.camel@citrix.com>
References: <1443455775-26131-1-git-send-email-anthony.perard@citrix.com>
	<1443455775-26131-3-git-send-email-anthony.perard@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1443455775-26131-3-git-send-email-anthony.perard@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xen.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-09-28 at 16:56 +0100, Anthony PERARD wrote:

> +  # Ignore these tests:
> +  # tempest.scenario.test_volume_boot_pattern.TestVolumeBootPattern.test_volume_boot_pattern
> +  #   It try to start a guest with /dev/vda as boot device name.
> +  $ignored_tests .= '|.*TestVolumeBootPattern.test_volume_boot_pattern';

Don't you need to escape the second "." for the regex context in the
tempest script? \Q and \E might be helpful for this?

Also, you actually ignore any test ending with that string, not just the
exact one in the comment, is that deliberate? Also any test with a longer
name which has this substring will also be ignored.

If not then you could put the common prefix into a variable to avoid
repeating it (and the very long lines) and maybe add some anchors?

You might also want to consider

    push @ignored_tests, "^$prefix\QTestVolumeBootPattern.test_volume_boot_pattern$";

Then later:
    $ignored_tests = join("|", @ignored_tests);

(I'm not sure, but I don't think you want qr{} [0] here, I might be wrong
though)

> +  # tempest.scenario.test_shelve_instance.TestShelveInstance.test_shelve_volume_backed_instance
> +  #   It try to start a guest with /dev/vda as boot device name.
> +  $ignored_tests .= '|.*TestShelveInstance.test_shelve_volume_backed_instance';
> +  # scenario.test_volume_boot_pattern.TestVolumeBootPatternV2.test_volume_boot_pattern
> +  #   It access a volume through iSCSI. This does not work when both the
> +  #   server and client of iSCSI are on the same Xen host, Linux 4.0 is the
> +  #   first Linux to have a fix.
> +  $ignored_tests .= '|.*TestVolumeBootPatternV2.test_volume_boot_pattern';
> +
> +  # Adding the tests to skip to the default regex.
> +  my $regex = "(?!.*\\[.*\\bslow\\b.*\\]$ignored_tests)(^tempest\\.(api|scenario|thirdparty))";

Where the default regex is:
    "(?!.*\\[.*\\bslow\\b.*\\])(^tempest\\.(api|scenario|thirdparty))";
?

This is a pretty rubbish interface which tempest has given you. What a
pain!

Ian

[0] http://perldoc.perl.org/perlop.html#Regexp-Quote-Like-Operators