From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH OSSTEST v3 3/3] Create a flight to test
 OpenStack with xen-unstable and libvirt
Date: Tue, 29 Sep 2015 16:49:29 +0100
Message-ID: <1443541769.16718.124.camel@citrix.com>
References: <1443455775-26131-1-git-send-email-anthony.perard@citrix.com>
	<1443455775-26131-4-git-send-email-anthony.perard@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1443455775-26131-4-git-send-email-anthony.perard@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Anthony PERARD <anthony.perard@citrix.com>, xen-devel@lists.xen.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-09-28 at 16:56 +0100, Anthony PERARD wrote:
> diff --git a/cri-common b/cri-common
> index c874ff9..66d13d1 100644
> --- a/cri-common
> +++ b/cri-common
> @@ -79,6 +79,7 @@ select_xenbranch () {
>  > 	> ovmf)> 	> 	> 	> tree=ovmf;> 	> xenbranch=xen-unstable ;;
>  > 	> distros-*)> 	> 	> tree=none;> 	> xenbranch=xen-unstable ;;
>  > 	> osstest)> 	> 	> tree=osstest;> 	> xenbranch=xen-unstable ;;
> +> 	> openstack)> 	> 	> tree=devstack;> 	> xenbranch=xen-unstable ;;

Is this "devstack" a left over which should have become openstack-nova like
the others?

@@ -621,6 +636,25 @@ test_matrix_do_one () {
>  
>    do_pygrub_tests
>    do_pvgrub_tests
> +
> +  job_create_test test-$xenarch$kern-$dom0arch-devstack \
> +    test-devstack libvirt $xenarch $dom0arch \
> +    tree_devstack=$TREE_OPENSTACK_DEVSTACK \
> +    tree_requirements=$TREE_OPENSTACK_REQUIREMENTS \
> +    tree_keystone=$TREE_OPENSTACK_KEYSTONE \
> +    tree_glance=$TREE_OPENSTACK_GLANCE \
> +    tree_cinder=$TREE_OPENSTACK_CINDER \
> +    tree_nova=$TREE_OPENSTACK_NOVA \
> +    tree_tempest=$TREE_OPENSTACK_TEMPEST \
> +    revision_devstack=master \
> +    revision_requirements=master \
> +    revision_keystone=master \
> +    revision_glance=master \
> +    revision_cinder=master \
> +    revision_nova=master \

This one wants to be $REVISION_OPENSTACK_NOVA which comes from the new call
to determine_revision which you added.

If what you get when you do a bare git clone of $TREE_OPENSTACK_NOVA is not
master then to support standalone mode you might want
${REVISION_OPENSTACK_NOVA:-master} to set the default for non-cr-daily
-branch callers.

Ian.