From: Ian Campbell <ian.campbell@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xenproject.org
Subject: Re: [OSSTEST PATCH 2/1] ts-hosts-allocate-Executive: Finish a couple of transactions
Date: Tue, 29 Sep 2015 17:03:03 +0100 [thread overview]
Message-ID: <1443542583.16718.136.camel@citrix.com> (raw)
In-Reply-To: <1443540459-31266-1-git-send-email-ian.jackson@eu.citrix.com>
On Tue, 2015-09-29 at 16:27 +0100, Ian Jackson wrote:
> Call $equivflagscheckq->finish() at the end, rather than in the
> candidate search loop. This avoids missing a `next' control path.
>
> Call $resprop_q->finish() at all.
>
> One of these is responsible for this message:
>
> DBI::db=HASH(0x88e79c4)->disconnect invalidates 1 active statement
> handle (either destroy statement handles or call finish on them
> before disconnecting) at Osstest/Executive.pm line 708, <GEN4> line
> 53.
>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
prev parent reply other threads:[~2015-09-29 16:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 14:14 [OSSTEST PATCH] ts-hosts-allocate-Executive: Do not allocate specific host with wrong blessing Ian Jackson
2015-09-29 14:30 ` Ian Campbell
2015-09-29 16:34 ` Ian Jackson
2015-09-29 15:27 ` [OSSTEST PATCH 2/1] ts-hosts-allocate-Executive: Finish a couple of transactions Ian Jackson
2015-09-29 15:27 ` [OSSTEST PATCH 3/1] ts-hosts-allocate-Executive: Print more info about booking to main log Ian Jackson
2015-09-29 16:08 ` Ian Campbell
2015-09-29 16:28 ` Ian Jackson
2015-09-29 16:03 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443542583.16718.136.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.