All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Alejandro Hernandez <alejandro.hernandez@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] archiver.bbclass: Fix archiver for gcc packages using patched sources
Date: Tue, 29 Sep 2015 23:55:06 +0100	[thread overview]
Message-ID: <1443567306.5162.62.camel@linuxfoundation.org> (raw)
In-Reply-To: <64ff08ec839f8d92b942c846bc2975362275aed2.1443548707.git.alejandro.hernandez@linux.intel.com>

On Tue, 2015-09-29 at 17:45 +0000, Alejandro Hernandez wrote:
> gcc packages use a shared source directory, this causes an issue since
> the archiver will try to patch the same source several times (one for
> each gcc package), producing an error, the archiver class used stamp-base
> to check this, nonetheless our gcc packages no longer use stamp-base,
> they use gcc-shared instead, which is what broke this functionality
> this patch adds a check to see whether or not the source should be patched,
> avoiding patching the source when it shouldnt.

Surely the source archiver shouldn't be doing *anything* if SRC_URI is
empty?

We don't need 20 copies of the gcc source code.

Cheers,

Richard



      reply	other threads:[~2015-09-29 22:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1443548707.git.alejandro.hernandez@linux.intel.com>
2015-09-29 17:45 ` [PATCH 1/1] archiver.bbclass: Fix archiver for gcc packages using patched sources Alejandro Hernandez
2015-09-29 22:55   ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443567306.5162.62.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=alejandro.hernandez@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.