All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Chao Peng <chao.p.peng@linux.intel.com>
Cc: wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	dario.faggioli@citrix.com, Ian.Jackson@eu.citrix.com,
	xen-devel@lists.xen.org, lars.kurth@ctrix.com
Subject: Re: [PATCH v2 for Xen 4.6 5/6] docs: make xl-psr.markdown more precise
Date: Wed, 30 Sep 2015 09:57:31 +0100	[thread overview]
Message-ID: <1443603451.16718.167.camel@citrix.com> (raw)
In-Reply-To: <20150930013435.GH5813@pengc-linux.bj.intel.com>

On Wed, 2015-09-30 at 09:34 +0800, Chao Peng wrote:
> On Tue, Sep 29, 2015 at 10:55:40AM +0100, Ian Campbell wrote:
> > On Tue, 2015-09-29 at 10:27 +0100, Andrew Cooper wrote:
> > > On 29/09/15 08:49, Chao Peng wrote: 
> > > >  [1] Intel SDM
> > > > -(http://www.intel.com/content/www/us/en/processors/architectures-s
> > > > oftw
> > > > are-developer-manuals.html).
> > > > +(http://www.intel.com/content/dam/www/public/us/en/documents/manua
> > > > ls/6
> > > > 4-ia-32-architectures-software-developer-system-programming-manual
> > > > -325384.pdf).
> > > 
> > > The other two changes look fine, but this change now points to a
> > > specific instance of the SDM, not the most recent version.  I would
> > > leave the link as it previously was.
> > 
> > I agree, we either want a specific revision with specific chapter
> > numbers
> > _or_ an up to date revision with just the titles and no specific
> > chapter
> > numbers. This commit removes the chapter numbers but switches to a
> > specific
> > revision, which is undesirable IMHO.
> > 
> > I therefore intend to drop this last hunk during commit.
> 
> I feel confortable, too.

Thanks for confirming.

>  Actually this is a suggestion from Lars during
> he reviewing the documents for the 4.6 release. Because when one opens
> the generic page he/she will see several options (combined volume set,
> three-volume set and seven-volume set), it may be not easy to find out
> the related chapters and especially because we have chapter number which
> is actually from the three-volume set, in such case it does look a bit
> confusing.

Right. Would it be worth mentioning the specific volume which is of
interest as a guide?

> 
> As now we have removed the chapter number, then the confusion doesn't
> exit because one can grab any volume set and will find the related
> chapters. I think this addressed Lars' concern.
> 
> Chao
> 

  reply	other threads:[~2015-09-30  8:57 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-29  7:49 [PATCH v2 for Xen 4.6 0/6] Several PSR fixes in libxl Chao Peng
2015-09-29  7:49 ` [PATCH v2 for Xen 4.6 1/6] tools/libxl: introduce libxl_get_online_socketmap Chao Peng
2015-09-29  9:10   ` Dario Faggioli
2015-09-29  9:22   ` Wei Liu
2015-09-29  7:49 ` [PATCH v2 for Xen 4.6 2/6] tools/libxl: fix socket display error for CMT Chao Peng
2015-09-29  9:06   ` Dario Faggioli
2015-09-29  7:49 ` [PATCH v2 for Xen 4.6 3/6] tools/libxl: return socket id from libxl_psr_cat_get_l3_info Chao Peng
2015-09-29  9:09   ` Dario Faggioli
2015-09-29  9:22   ` Wei Liu
2015-09-29  7:49 ` [PATCH v2 for Xen 4.6 4/6] tools/libxl: fix range check in main_psr_cat_cbm_set Chao Peng
2015-09-29  7:49 ` [PATCH v2 for Xen 4.6 5/6] docs: make xl-psr.markdown more precise Chao Peng
2015-09-29  9:27   ` Andrew Cooper
2015-09-29  9:55     ` Ian Campbell
2015-09-30  1:34       ` Chao Peng
2015-09-30  8:57         ` Ian Campbell [this message]
2015-09-30  9:40           ` Chao Peng
2015-09-29  7:49 ` [PATCH v2 for Xen 4.6 6/6] docs/man: resort sections Chao Peng
2015-09-29  8:53   ` Dario Faggioli
2015-09-29  9:02   ` Wei Liu
2015-09-29  9:33 ` [PATCH v2 for Xen 4.6 0/6] Several PSR fixes in libxl Wei Liu
2015-09-29 10:30   ` Ian Campbell
2015-09-30  1:36     ` Chao Peng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443603451.16718.167.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=chao.p.peng@linux.intel.com \
    --cc=dario.faggioli@citrix.com \
    --cc=lars.kurth@ctrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.