From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] xen/arm: Correctly read the GICv3
	Re-Distributor stride
Date: Wed, 30 Sep 2015 14:30:59 +0100
Message-ID: <1443619859.16718.190.camel@citrix.com>
References: <560BBF70.7030205@huawei.com>
	<1443611055.16718.184.camel@citrix.com>
	<5FC3163CFD30C246ABAA99954A238FA81728BEF3@lhreml504-mbs>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=7082c434e=Ian.Campbell@citrix.com>)
	id 1ZhHTQ-0008Qf-O3
	for xen-devel@lists.xenproject.org; Wed, 30 Sep 2015 13:31:08 +0000
In-Reply-To: <5FC3163CFD30C246ABAA99954A238FA81728BEF3@lhreml504-mbs>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "julien.grall@citrix.com" <julien.grall@citrix.com>, "vijaya.kumar@caviumnetworks.com" <vijaya.kumar@caviumnetworks.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-09-30 at 11:29 +0000, Shameerali Kolothum Thodi wrote:
> 
> > -----Original Message-----
> > From: Ian Campbell [mailto:ian.campbell@citrix.com]
> > Sent: 30 September 2015 12:04
> > To: Shameerali Kolothum Thodi; xen-devel@lists.xenproject.org
> > Cc: julien.grall@citrix.com; vijaya.kumar@caviumnetworks.com
> > Subject: Re: [PATCH] xen/arm: Correctly read the GICv3 Re-Distributor
> > stride
> > 
> > On Wed, 2015-09-30 at 11:54 +0100, Shameerali Kolothum Thodi wrote:
> > > The GICv3 driver read a 32 bit value for the re-distributor stride,
> > > but the dts binding is a two-cell property.
> > 
> > The binding doc I have says:
> > 
> > - redistributor-stride : If using padding pages, specifies the stride
> >   of consecutive redistributors. Must be a multiple of 64kB.
> > 
> > i.e. it doesn't say anything about the size. The _example_ is 2 cells,
> > but I don't think that is normative.
> > 
> > Unless you can point to a bindings update which specifies strictly two
> > cells then I think the right answer is the use dt_read_number.
> 
> You are right. The binding text is not clear. But Linux gic driver from the
> beginning is using the 64 bit value.

The Linux gic driver is also not a normative declaration of the spec.

I think the spec needs to be clarified and then Linux and/or Xen need to be
fixed to follow the spec.

Ian.