From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [OSSTEST PATCH] Executive HTML output: Use #888888
 (grey) for queued jobs
Date: Wed, 30 Sep 2015 16:28:52 +0100
Message-ID: <1443626932.16718.197.camel@citrix.com>
References: <1443625514-23716-1-git-send-email-ian.jackson@eu.citrix.com>
	<22027.64408.593428.933572@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=7082c434e=Ian.Campbell@citrix.com>)
	id 1ZhJJR-0006jO-CB
	for xen-devel@lists.xenproject.org; Wed, 30 Sep 2015 15:28:57 +0000
In-Reply-To: <22027.64408.593428.933572@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-09-30 at 16:11 +0100, Ian Jackson wrote:
> Ian Jackson writes ("[OSSTEST PATCH] Executive HTML output: Use #888888
> (grey) for queued jobs"):
> > Either the flight hasn't started yet, or the job is blocked waiting
> > for other jobs to finish.  In any case their state is not very
> > interesting.
> > 
> > Most usefully this change visually distinguishes, in the plan summary,
> > jobs which are waiting for prior jobs to finish, from ones which have
> > entered the planning queue.
> 
> I didn't test this.  Ideally it would be tested by applying to the
> thing which is currently generating /~ianc/summary.html on the
> production VM.

I've just thrown it in there.

> > +    } elsif ($status eq '(queued)') {
> > +        return $single->("($status)", $grey),
> 
> The '(queued)' is wrong.
> 
> Ian.
> 
> From f0d8434ae0414b97898e67be5681c6d7e5318e14 Mon Sep 17 00:00:00 2001
> From: Ian Jackson <ian.jackson@eu.citrix.com>
> Date: Wed, 30 Sep 2015 16:02:49 +0100
> Subject: [OSSTEST PATCH] Executive HTML output: Use #888888 (grey) for
> queued
>  jobs
> 
> Either the flight hasn't started yet, or the job is blocked waiting
> for other jobs to finish.  In any case their state is not very
> interesting.
> 
> Most usefully this change visually distinguishes, in the plan summary,
> jobs which are waiting for prior jobs to finish, from ones which have
> entered the planning queue.
> 
> Also replace a $f->{status} with $status, which is less confusing.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

> ---
> v2: Get test right.
>     Update commit message.
> ---
>  Osstest/Executive.pm |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm
> index aeb8c25..4cc34c7 100644
> --- a/Osstest/Executive.pm
> +++ b/Osstest/Executive.pm
> @@ -221,6 +221,7 @@ our $red=    '#ff8888';
>  our $yellow= '#ffff00';
>  our $purple= '#ff00ff';
>  our $blue=   '#0000ff';
> +our $grey=   '#888888';
>  
>  sub report_run_getinfo ($) {
>      # $f is a joined flight/job row, must contain at least
> @@ -272,8 +273,10 @@ END
>  	};
>      } elsif ($status eq 'blocked') {
>          return $single->("blocked", $purple),
> +    } elsif ($status eq 'queued') {
> +        return $single->("($status)", $grey),
>      } else {
> -        return $single->("($f->{status})", $yellow);
> +        return $single->("($status)", $yellow);
>      }
>  }
>