From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "\"T?th Attila\"" <atoth@atoth.sote.hu>,
adam radford <aradford@gmail.com>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: twa generates WARNING upon boot
Date: Wed, 30 Sep 2015 09:43:28 -0700 [thread overview]
Message-ID: <1443631408.2185.32.camel@HansenPartnership.com> (raw)
In-Reply-To: <20150930164123.GA24596@infradead.org>
On Wed, 2015-09-30 at 09:41 -0700, Christoph Hellwig wrote:
> On Wed, Sep 30, 2015 at 09:36:24AM -0700, James Bottomley wrote:
> > Are you sure? The init trace that kicked all this off still has
> > twa_init in it. I was figuring the most likely suspect is
> > twa_get_param().
>
> That one doesnt set ->srb at all, but given that it's called before
> any SCSI commands can sent ->srb will be all NULL. It certainly
> doesn't use a scsi_cmnd anywhere and does not expect to hit any
> code path calling scsi_dma_unmap. If it ends up there it's a bad bug
> and would blow up a lot more spectacularly.
OK, post a compilable version of the patch and lets get the reporter to
try it out. Not resurrecting esoteric flags suits me.
James
next prev parent reply other threads:[~2015-09-30 16:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-27 11:56 twa generates WARNING upon boot "Tóth Attila"
2015-09-27 21:19 ` adam radford
2015-09-29 16:49 ` "Tóth Attila"
2015-09-29 17:37 ` James Bottomley
2015-09-29 18:02 ` James Bottomley
2015-09-29 18:25 ` "Tóth Attila"
2015-09-29 18:33 ` James Bottomley
2015-09-30 16:08 ` Christoph Hellwig
2015-09-30 16:15 ` James Bottomley
2015-09-30 16:31 ` Christoph Hellwig
2015-09-30 16:36 ` James Bottomley
2015-09-30 16:41 ` Christoph Hellwig
2015-09-30 16:43 ` James Bottomley [this message]
2015-09-30 16:44 ` Christoph Hellwig
2015-09-30 20:18 ` "Tóth Attila"
2015-09-30 16:20 ` kbuild test robot
-- strict thread matches above, loose matches on Subject: below --
2015-09-28 5:55 "Tóth Attila"
2015-09-29 19:17 "Tóth Attila"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443631408.2185.32.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=aradford@gmail.com \
--cc=atoth@atoth.sote.hu \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.