From: Johannes Berg <johannes@sipsolutions.net>
To: Josh Boyer <jwboyer@fedoraproject.org>
Cc: drago01 <drago01@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>
Subject: Re: Rate limiting AP bandwidth change messages in ieee80211_config_bw?
Date: Wed, 30 Sep 2015 20:32:17 +0200 [thread overview]
Message-ID: <1443637937.1859.19.camel@sipsolutions.net> (raw)
In-Reply-To: <CA+5PVA4yaLG2NtJ_Bg5-BQzR-Wa5ABxPb-cLxF7bjSsf-P1_5Q@mail.gmail.com> (sfid-20150930_190254_762697_55F052FA)
On Wed, 2015-09-30 at 13:02 -0400, Josh Boyer wrote:
> Hi Johannes,
>
> We've seen a handful of reports that seem to have verbose output from
> the ieee80211_config_bw function in net/mac80211/mlme.c. It looks
> similar to this:
>
> [ 66.578652] wlp3s0: AP xx:xx:xx:xx:xx changed bandwidth, new config
> is 2437 MHz, width 2 (2447/0 MHz)
> [ 68.522437] wlp3s0: AP xx:xx:xx:xx:xx changed bandwidth, new config
> is 2437 MHz, width 1 (2437/0 MHz)
> Essentially, this looks like the AP is changing the bandwidth (and
> only the width) every second or so. Why it is doing this, I'm not
> sure. However, this doesn't seem to actually be an error case yet the
> kernel logs are getting spammed with this message.
>
> I'm wondering if we could either change this message to use sdata_dbg
> instead of sdata_info, or if we could possibly ratelimit it somehow.
> I'd be happy to come up with a patch for either, but I wanted to get
> your feedback on it before I started. Do you have any objections or
> preference?
>
I'm not sure ratelimiting it would even work - it's not *that* high
frequency? Not really sure though.
I think we can do either, it's not such a terribly important message as
far as I can tell.
johannes
next prev parent reply other threads:[~2015-09-30 18:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 17:02 Rate limiting AP bandwidth change messages in ieee80211_config_bw? Josh Boyer
2015-09-30 18:32 ` Johannes Berg [this message]
2015-09-30 19:04 ` Johannes Berg
2015-10-01 0:09 ` Josh Boyer
2015-10-01 7:48 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443637937.1859.19.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=drago01@gmail.com \
--cc=jwboyer@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.