From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] build: drop unused SUBARCH variable Date: Thu, 1 Oct 2015 09:55:24 +0100 Message-ID: <1443689724.16718.227.camel@citrix.com> References: <1442601664-7600-1-git-send-email-cardoe@cardoe.com> <560C22B8.30907@cardoe.com> <560CF25002000078000A74EE@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <560CF25002000078000A74EE@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , Doug Goldstein Cc: Keir Fraser , Tim Deegan , Ian Jackson , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Thu, 2015-10-01 at 00:44 -0600, Jan Beulich wrote: > > > > On 30.09.15 at 19:58, wrote: > > On 9/18/15 1:41 PM, Doug Goldstein wrote: > > > This variable appears to be unused throughout the code base. > > > > > > Signed-off-by: Doug Goldstein > > > --- > > > Makefile | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/Makefile b/Makefile > > > index 75177f0..8a9331f 100644 > > > --- a/Makefile > > > +++ b/Makefile > > > @@ -35,8 +35,7 @@ mini-os-dir-force-update: mini-os-dir > > > $(GIT) reset --hard $(MINIOS_UPSTREAM_REVISION); \ > > > fi > > > > > > -SUBARCH := $(subst x86_32,i386,$(XEN_TARGET_ARCH)) > > > -export XEN_TARGET_ARCH SUBARCH > > > +export XEN_TARGET_ARCH > > > export DESTDIR > > > > > > # build and install everything into the standard system directories > > > > > > > ping? > > This was applied over a week ago. Did you check the tree before > pinging? I've updated http://wiki.xen.org/wiki/Submitting_Xen_Project_Patches to mention that people should check staging. Ian.