From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Mark Hatle <mark.hatle@windriver.com>
Cc: david.reyna@windriver.com, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] "Finish" the IMAGE_GEN_DEBUGFS implementation
Date: Thu, 01 Oct 2015 23:31:01 +0100 [thread overview]
Message-ID: <1443738661.14733.71.camel@linuxfoundation.org> (raw)
In-Reply-To: <1443723968-43906-1-git-send-email-mark.hatle@windriver.com>
On Thu, 2015-10-01 at 13:26 -0500, Mark Hatle wrote:
> It was noticed today that the IMAGE_GEN_DEBUGFS implementation was not
> complete. The version that was merged back in May only contained the
> filesystem generation pieces, but not the pieces for creating the image
> from that filesystem.
>
> The code has been tested and is working. The only thing that I don't
> particularly like is that the processing code and loop is a duplicate of
> the code that runs just before. Unfortunately the only way around this
> is to change the way that way the parallel bits are processed to support
> multiple datastores.. (or create "another" function..)
>
> Any feedback appreciated, but without this the feature is broken!
Could we not make a function which these two code points then call?
Cheers,
Richard
next prev parent reply other threads:[~2015-10-01 22:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 18:26 [PATCH] "Finish" the IMAGE_GEN_DEBUGFS implementation Mark Hatle
2015-10-01 18:26 ` [PATCH] lib/oe/image.py: Add image generation for companion debug filesystem Mark Hatle
2015-10-01 22:31 ` Richard Purdie [this message]
2015-10-02 14:23 ` [PATCH] "Finish" the IMAGE_GEN_DEBUGFS implementation Mark Hatle
2015-10-02 14:30 ` Richard Purdie
2015-10-02 14:50 ` Mark Hatle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443738661.14733.71.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=david.reyna@windriver.com \
--cc=mark.hatle@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.