From: Ian Campbell <ian.campbell@citrix.com>
To: Juergen Gross <jgross@suse.com>,
xen-devel@lists.xen.org, ian.jackson@eu.citrix.com,
stefano.stabellini@eu.citrix.com, wei.liu2@citrix.com
Subject: Re: [PATCH v2 1/5] libxc: remove allocate member from struct xc_dom_image
Date: Fri, 2 Oct 2015 14:01:24 +0100 [thread overview]
Message-ID: <1443790884.11707.97.camel@citrix.com> (raw)
In-Reply-To: <1443764987-23639-2-git-send-email-jgross@suse.com>
On Fri, 2015-10-02 at 07:49 +0200, Juergen Gross wrote:
> The allocate() callback in struct xc_dom_image is never set. Remove it.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
This breaks the stubdom build:
kexec.c: In function ‘kexec’:
kexec.c:221:78: warning: taking address of expression of type ‘void’
xen_pfn_t boot_page_mfn = virt_to_mfn(&_boot_page);
^
kexec.c:230:8: error: ‘struct xc_dom_image’ has no member named ‘allocate’
dom->allocate = kexec_allocate;
^
kexec.c:318:60: warning: taking address of expression of type ‘void’
virt_to_mfn(&_boot_page));
^
Makefile:79: recipe for target '/local/scratch/ianc/devel/committer-amd64.git/stubdom/grub-x86_64/kexec.o' failed
On i386 too.
And in fact that hook looks useful in that context, so either it needs to
stay of stubdom kexec needs changing to work some other way.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2015-10-02 13:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 5:49 [PATCH v2 0/5] libxc: support building large pv-domains Juergen Gross
2015-10-02 5:49 ` [PATCH v2 1/5] libxc: remove allocate member from struct xc_dom_image Juergen Gross
2015-10-02 13:01 ` Ian Campbell [this message]
2015-10-02 14:25 ` Juergen Gross
2015-10-02 14:47 ` Ian Campbell
2015-10-02 15:00 ` Juergen Gross
2015-10-02 5:49 ` [PATCH v2 2/5] xen: add generic flag to elf_dom_parms indicating support of unmapped initrd Juergen Gross
2015-10-02 9:37 ` Andrew Cooper
2015-10-02 9:41 ` Jan Beulich
2015-10-02 9:44 ` Juergen Gross
2015-10-02 9:53 ` Andrew Cooper
2015-10-02 10:01 ` Juergen Gross
2015-10-02 10:22 ` Ian Campbell
2015-10-02 5:49 ` [PATCH v2 3/5] libxc: create unmapped initrd in domain builder if supported Juergen Gross
2015-10-02 12:59 ` Ian Campbell
2015-10-02 14:46 ` Juergen Gross
2015-10-02 14:56 ` Ian Campbell
2015-10-02 15:13 ` Juergen Gross
2015-10-02 15:21 ` Ian Campbell
2015-10-02 16:28 ` Juergen Gross
2015-10-02 5:49 ` [PATCH v2 4/5] libxc: split p2m allocation in domain builder from other magic pages Juergen Gross
2015-10-02 9:29 ` Ian Campbell
2015-10-02 5:49 ` [PATCH v2 5/5] libxc: create p2m list outside of kernel mapping if supported Juergen Gross
2015-10-02 13:16 ` Ian Campbell
2015-10-02 14:37 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443790884.11707.97.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.