Re: pyxc_linux_build() in tools/python/xen/lowlevel/xc/xc.c still needed?

[Ian Campbell <ian.campbell@citrix.com>]

On Tue, 2015-10-06 at 12:56 +0200, Juergen Gross wrote:
> On 10/06/2015 10:56 AM, Ian Campbell wrote:
> > On Tue, 2015-10-06 at 08:33 +0200, Juergen Gross wrote:
> > > Do we have any requirements to be compatible to old releases
> > > regarding
> > > the functions in tools/python/xen/lowlevel/xc/xc.c ?
> > 
> > IMHO, no.
> > 
> > There are also too many compatibility shims in front of the domain
> > builder,
> > i.e. all the stuff in tools/libxc/xc_dom_compat_linux.c which IMHO
> > could be
> > nuked too.
> 
> Hmm, all of the functions there are defined in xenguest.h and are
> probably used by out-of-tree components.
> 
> xc_linux_build() is used in qemu-xen in file /hw/xenpv/xen_domainbuild.c
> 
> Is it really okay to remove all of this stuff?

In general, yes, I think so. But in the specific case of xc_linux_build I
suppose not, at least for now.

As part of my series to split up libxenctrl I noticed that the QEMU support
for domain building couldn't possibly have worked (according to a code
comment) since Xen 4.1 and I've got a patch to make it a compile time
option.

Ian