From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752657AbbJFMZV (ORCPT ); Tue, 6 Oct 2015 08:25:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41682 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751616AbbJFMZS (ORCPT ); Tue, 6 Oct 2015 08:25:18 -0400 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra Subject: [PATCH 1/3] perf tools: Get rid of superfluos call to reset_dimensions Date: Tue, 6 Oct 2015 14:25:10 +0200 Message-Id: <1444134312-29136-2-git-send-email-jolsa@kernel.org> In-Reply-To: <1444134312-29136-1-git-send-email-jolsa@kernel.org> References: <1444134312-29136-1-git-send-email-jolsa@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There's no need to call reset_dimensions within __setup_output_field function. It's already called in its caller setup_sorting right before perf_hpp__init, which will be changed in following patch to respect taken dimension. Link: http://lkml.kernel.org/n/tip-08mxvkxtuxbboog1exjok9gd@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/util/sort.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c index ee94b728fca4..8521e3c89b8d 100644 --- a/tools/perf/util/sort.c +++ b/tools/perf/util/sort.c @@ -1917,8 +1917,6 @@ static int __setup_output_field(void) if (field_order == NULL) return 0; - reset_dimensions(); - strp = str = strdup(field_order); if (str == NULL) { error("Not enough memory to setup output fields"); -- 2.4.3