From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v2 2/9] xen/arm: io: Extend write/read
 handler to pass the register in parameter
Date: Tue, 6 Oct 2015 14:44:01 +0100
Message-ID: <1444139041.5302.176.camel@citrix.com>
References: <1444049512-15323-1-git-send-email-julien.grall@citrix.com>
	<1444049512-15323-3-git-send-email-julien.grall@citrix.com>
	<561273DC.6080500@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=7140158d9=Ian.Campbell@citrix.com>)
	id 1ZjSXF-0007Ww-Gf
	for xen-devel@lists.xenproject.org; Tue, 06 Oct 2015 13:44:05 +0000
In-Reply-To: <561273DC.6080500@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@citrix.com>, xen-devel@lists.xenproject.org
Cc: stefano.stabellini@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-10-05 at 13:58 +0100, Julien Grall wrote:
> On 05/10/15 13:51, Julien Grall wrote:
> > Rather than letting each handler to retrieve the register used by the
> > I/O access, add a new parameter to pass the register in parameter.
> > 
> > This will help to implement generic register manipulation on I/O access
> > such as sign-extension and endianess.
> > 
> > Read handlers need to modify the value of the register, so a pointer to
> > it is given in argument. Write handlers shouldn't modify the register,
> > therefore only a plain value is given.
> > 
> > Signed-off-by: Julien Grall <julien.grall@citrix.com>
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > 
> > ---
> > 
> > Ian, I haven't kept my Acked-by because of code clash while rebasing
> > on top of "xen/arm: io: Extend write/read handler to pass private data"
> > [1].
> 
> Hmmm, this doesn't match what I did (i.e keeping the acked-by from Ian).
> 
> The conflict with "xen/arm: io: Extend write/read handler to pass
> private data" should not be controversial. Let me know if you disagree.

It's fine.