From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 3/9] xen/arm: io: Support sign-extension for every read access Date: Tue, 6 Oct 2015 14:47:00 +0100 Message-ID: <1444139220.5302.177.camel@citrix.com> References: <1444049512-15323-1-git-send-email-julien.grall@citrix.com> <1444049512-15323-4-git-send-email-julien.grall@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZjSa8-0007nj-Jv for xen-devel@lists.xenproject.org; Tue, 06 Oct 2015 13:47:04 +0000 In-Reply-To: <1444049512-15323-4-git-send-email-julien.grall@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall , xen-devel@lists.xenproject.org Cc: stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On Mon, 2015-10-05 at 13:51 +0100, Julien Grall wrote: > [...] > + /* > + * Sign extend if required. > + * Note that we expect the read handler to have zeroed the bit > + * unused in the register. You were (correctly) going to change this to Note that we expect the read handler to have zeroed the bits outside the requested access size. Apart from that (which I can fix on commit): Acked-by: Ian Campbell