From: "Koul, Vinod" <vinod.koul@intel.com>
To: "broonie@kernel.org" <broonie@kernel.org>,
"Lin, Mengdong" <mengdong.lin@intel.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"tiwai@suse.de" <tiwai@suse.de>,
"liam.r.girdwood@linux.intel.com"
<liam.r.girdwood@linux.intel.com>,
"Kp, Jeeja" <jeeja.kp@intel.com>,
"Prusty, Subhransu S" <subhransu.s.prusty@intel.com>,
"Patel, Vedang" <vedang.patel@intel.com>
Subject: Re: [PATCH v2 4/8] ASoC: topology: ABI - Add name element to snd_soc_tplg_stream
Date: Tue, 6 Oct 2015 15:16:30 +0000 [thread overview]
Message-ID: <1444144590.25504.27.camel@intel.com> (raw)
In-Reply-To: <20151006103403.GH12635@sirena.org.uk>
On Tue, 2015-10-06 at 11:34 +0100, Mark Brown wrote:
> On Tue, Oct 06, 2015 at 08:55:58AM +0000, Lin, Mengdong wrote:
>
> > > > OK, so this means that every DAI link name is going to become an ABI
> > > > too if there's a topology in there. Not a problem but we'll need to
> > > > watch out for that on review... I wonder if I can make some automated
> > > > checker thing.
>
> > Do you mean we need to check if a DAI link name is already used, or if it's a
> > valid string?
>
> No, I mean that if someone changes a name it'll invalidate topology
> files that reference that name.
Shouldn't this sort be checked in the alsa-lib while building the topology. It should
validate the names, graph and complete only when stuff is right.
--
~Vinod
next prev parent reply other threads:[~2015-10-06 15:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 9:28 [PATCH v2 0/8] ASoC: topology: ABI - Add support for PCM, BE & CC link mengdong.lin
2015-09-30 9:28 ` [PATCH v2 1/8] ASoC: topology: ABI - Add PCM Support and bump ABI version to 4 mengdong.lin
2015-09-30 9:29 ` [PATCH v2 2/8] ASoC: topology: ABI - Remove unused struct snd_soc_tplg_stream_config mengdong.lin
2015-09-30 9:30 ` [PATCH v2 3/8] ASoC: topology: ABI - Use __le32 instead of __u32 in snd_soc_tplg_dapm_widget mengdong.lin
2015-09-30 9:31 ` [PATCH v2 4/8] ASoC: topology: ABI - Add name element to snd_soc_tplg_stream mengdong.lin
2015-10-02 16:59 ` Mark Brown
2015-10-02 18:04 ` Liam Girdwood
2015-10-06 8:55 ` Lin, Mengdong
2015-10-06 10:34 ` Mark Brown
2015-10-06 15:16 ` Koul, Vinod [this message]
2015-10-06 16:25 ` Mark Brown
2015-10-06 16:35 ` Lars-Peter Clausen
2015-10-06 17:36 ` Mark Brown
2015-10-07 9:48 ` Lin, Mengdong
2015-10-07 10:04 ` Takashi Iwai
2015-10-07 10:23 ` Mark Brown
2015-10-07 10:08 ` Mark Brown
2015-10-06 15:06 ` Lin, Mengdong
2015-09-30 9:31 ` [PATCH v2 5/8] ASoC: topology: ABI - Change stream formats to a bitwise flag mengdong.lin
2015-09-30 9:32 ` [PATCH v2 6/8] ASoC: topology: ABI - Add the type for BE DAI link mengdong.lin
2015-09-30 9:32 ` [PATCH v2 7/8] ASoC: topology: ABI - Add configuration for BE & Codec-Codec DAI Links mengdong.lin
2015-09-30 9:32 ` [PATCH v2 8/8] ASoC: topology: ABI - Remove tdm_slot & dai_fmt from snd_soc_tplg_stream mengdong.lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444144590.25504.27.camel@intel.com \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jeeja.kp@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=mengdong.lin@intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=tiwai@suse.de \
--cc=vedang.patel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.