Re: [PATCH XEN v3 11/22] tools: Remove xc_map_foreign_batch

[Ian Campbell <ian.campbell@citrix.com>]

On Wed, 2015-10-07 at 16:08 +0100, George Dunlap wrote:
> On 07/10/15 15:15, Ian Campbell wrote:
> > It can trivially be replaced by xc_map_foreign_bulk which is the
> > interface I want to move to going forward. All in tree users are
> > trivially converted by supplying the appropriate error array and
> > adjusting the what error handling exists (which in many cases is not
> > much).
> > 
> > This reduces the twist maze of xc_map_foreign_* by one, which will be
> > useful when trying to come up with an underlying stable interface.
> > 
> > NetBSD and Solaris implemented xc_map_foreign_bulk in terms of
> > xc_map_foreign_batch via a compat layer, so xc_map_foreign_batch
> > becomes an internal osdep for them. New OS ports should always
> > implement xc_map_foreign_bulk instead.
> > 
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> > Acked-by: George Dunlap <george.dunlap@citrix.com>
> > Cc: George Dunlap <george.dunlap@eu.citrix.com>
> > ---
> >  tools/libxc/include/xenctrl.h   | 10 -------
> >  tools/libxc/xc_foreign_memory.c |  4 ++-
> >  tools/libxc/xc_linux_osdep.c    | 59 +++------------------------------
> > --------
> >  tools/libxc/xc_minios.c         | 22 ---------------
> >  tools/libxc/xc_netbsd.c         | 10 +++----
> >  tools/libxc/xc_solaris.c        |  6 ++---
> >  tools/libxc/xc_vm_event.c       | 25 ++++++++++++-----
> >  tools/xenmon/xenbaked.c         | 19 ++++++++++---
> >  tools/xenpaging/pagein.c        |  4 ++-
> >  tools/xenpaging/xenpaging.c     | 12 +++++----
> >  tools/xentrace/xentrace.c       | 10 ++++---
> >  11 files changed, 63 insertions(+), 118 deletions(-)
> > 
> > diff --git a/tools/libxc/include/xenctrl.h
> > b/tools/libxc/include/xenctrl.h
> > index 0c6b36b..44d0496 100644
> > --- a/tools/libxc/include/xenctrl.h
> > +++ b/tools/libxc/include/xenctrl.h
> > @@ -1395,16 +1395,6 @@ void *xc_map_foreign_pages(xc_interface *xch,
> > uint32_t dom, int prot,
> >                             const xen_pfn_t *arr, int num );
> >  
> >  /**
> > - * DEPRECATED - use xc_map_foreign_bulk() instead.
> 
> I like how there are half a dozen places in tree where we've been using
> a deprecated function for years. :-)
> 
> In any case:
> 
> Acked-by: George Dunlap <george.dunlap@citrix.com>

It took me _ages_ to untangle all of these, each OS had implemented a
different subsets of the N interfaces as their base line and then there
were a variety of compat shims in terms of that which ended up providing
the full set on all platforms, sometimes it was A implemented in terms of B
and sometimes it was vice versa.

I had to resort to drawing a graph per target platform and then chopping
nodes out one by one to get anything I could even understand.

Ian.