From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga01.intel.com ([192.55.52.88]:20710 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753864AbbJHIa1 (ORCPT ); Thu, 8 Oct 2015 04:30:27 -0400 From: "Coelho, Luciano" To: "xerofoify@gmail.com" , "Berg, Johannes" CC: "linux-kernel@vger.kernel.org" , "Spinadel, David" , "Dreyfuss, Haim" , "Bondar, Alexander" , "ilw@linux.intel.com" , "kvalo@codeaurora.org" , "Stern, Avraham" , "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "Grumbach, Emmanuel" Subject: Re: [PATCH] iwlwifi:Fix incorrect fallthrough in switch statement in the function iwl_mvm_check_running_scans Date: Thu, 8 Oct 2015 08:30:22 +0000 Message-ID: <1444293021.2899.46.camel@intel.com> (sfid-20151008_103118_312126_23291515) References: <1442967859-16347-1-git-send-email-xerofoify@gmail.com> In-Reply-To: <1442967859-16347-1-git-send-email-xerofoify@gmail.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: T24gVHVlLCAyMDE1LTA5LTIyIGF0IDIwOjI0IC0wNDAwLCBOaWNob2xhcyBLcmF1c2Ugd3JvdGU6 DQo+IFRoaXMgZml4ZXMgaW5jb3JyZWN0IGZhbGx0aHJvdWdoIGluIHRoZSBzd2l0Y2ggc3RhdG1l bnQgY2hlY2tpbmcNCj4gdGhlIHNjYW4gdHlwZSBwYXNzZWQgYnkgdGhlIGNhbGxlciB0byBpd2xf bXZtX2NoZWNrX3J1bm5pbmdfc2NhbnMNCj4gZm9yIHRoZSBzd2l0Y2ggY2FzZSBJV0xfTVZNX1ND QU5fU0NIRUQgdG8gcmV0dXJuIGRpcmVjdGx5IGFmdGVyDQo+IHRoZSBjYWxsIHRvIGl3bF9tdm1f c2Nhbl9zdG9wIGluIG9yZGVyIHRvIGF2b2lkIGZhbGx0aHJvdWdoIGludG8NCj4gdGhlIG5leHQg Y2FzZSBhbmQgaW5jb3JyZWN0bHkgcmV0dXJuIHplcm8gaW5kaWNhdGluZyBzdWNjZXNzIHRvDQo+ IHRoZSBjYWxsZXIgZXZlbiBpZiB0aGUgZnVuY3Rpb24gY2FsbCB0byBpd2xfbXZtX3NjYW5fc3Rv cCBmYWlscy4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IE5pY2hvbGFzIEtyYXVzZSA8eGVyb2ZvaWZ5 QGdtYWlsLmNvbT4NCj4gLS0tDQoNCkFwcGxpZWQgdG8gb3VyIGludGVybmFsIHRyZWUgd2l0aCBh IG1vZGlmaWVkIGNvbW1pdCBtZXNzYWdlLg0KDQpUaGFua3MhDQoNCi0tDQpMdWNhLg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754001AbbJHIac (ORCPT ); Thu, 8 Oct 2015 04:30:32 -0400 Received: from mga01.intel.com ([192.55.52.88]:20710 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753864AbbJHIa1 (ORCPT ); Thu, 8 Oct 2015 04:30:27 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,654,1437462000"; d="scan'208";a="821990761" From: "Coelho, Luciano" To: "xerofoify@gmail.com" , "Berg, Johannes" CC: "linux-kernel@vger.kernel.org" , "Spinadel, David" , "Dreyfuss, Haim" , "Bondar, Alexander" , "ilw@linux.intel.com" , "kvalo@codeaurora.org" , "Stern, Avraham" , "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "Grumbach, Emmanuel" Subject: Re: [PATCH] iwlwifi:Fix incorrect fallthrough in switch statement in the function iwl_mvm_check_running_scans Thread-Topic: [PATCH] iwlwifi:Fix incorrect fallthrough in switch statement in the function iwl_mvm_check_running_scans Thread-Index: AQHQ9ZY1YBtZ5ANLKUKVH1xYvS07LJ5hSzOA Date: Thu, 8 Oct 2015 08:30:22 +0000 Message-ID: <1444293021.2899.46.camel@intel.com> References: <1442967859-16347-1-git-send-email-xerofoify@gmail.com> In-Reply-To: <1442967859-16347-1-git-send-email-xerofoify@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.194.248] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t988UdUD027999 On Tue, 2015-09-22 at 20:24 -0400, Nicholas Krause wrote: > This fixes incorrect fallthrough in the switch statment checking > the scan type passed by the caller to iwl_mvm_check_running_scans > for the switch case IWL_MVM_SCAN_SCHED to return directly after > the call to iwl_mvm_scan_stop in order to avoid fallthrough into > the next case and incorrectly return zero indicating success to > the caller even if the function call to iwl_mvm_scan_stop fails. > > Signed-off-by: Nicholas Krause > --- Applied to our internal tree with a modified commit message. Thanks! -- Luca.{.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Coelho, Luciano" Subject: Re: [PATCH] iwlwifi:Fix incorrect fallthrough in switch statement in the function iwl_mvm_check_running_scans Date: Thu, 8 Oct 2015 08:30:22 +0000 Message-ID: <1444293021.2899.46.camel@intel.com> References: <1442967859-16347-1-git-send-email-xerofoify@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "linux-kernel@vger.kernel.org" , "Spinadel, David" , "Dreyfuss, Haim" , "Bondar, Alexander" , "ilw@linux.intel.com" , "kvalo@codeaurora.org" , "Stern, Avraham" , "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "Grumbach, Emmanuel" To: "xerofoify@gmail.com" , "Berg, Johannes" Return-path: In-Reply-To: <1442967859-16347-1-git-send-email-xerofoify@gmail.com> Content-Language: en-US Content-ID: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org T24gVHVlLCAyMDE1LTA5LTIyIGF0IDIwOjI0IC0wNDAwLCBOaWNob2xhcyBLcmF1c2Ugd3JvdGU6 DQo+IFRoaXMgZml4ZXMgaW5jb3JyZWN0IGZhbGx0aHJvdWdoIGluIHRoZSBzd2l0Y2ggc3RhdG1l bnQgY2hlY2tpbmcNCj4gdGhlIHNjYW4gdHlwZSBwYXNzZWQgYnkgdGhlIGNhbGxlciB0byBpd2xf bXZtX2NoZWNrX3J1bm5pbmdfc2NhbnMNCj4gZm9yIHRoZSBzd2l0Y2ggY2FzZSBJV0xfTVZNX1ND QU5fU0NIRUQgdG8gcmV0dXJuIGRpcmVjdGx5IGFmdGVyDQo+IHRoZSBjYWxsIHRvIGl3bF9tdm1f c2Nhbl9zdG9wIGluIG9yZGVyIHRvIGF2b2lkIGZhbGx0aHJvdWdoIGludG8NCj4gdGhlIG5leHQg Y2FzZSBhbmQgaW5jb3JyZWN0bHkgcmV0dXJuIHplcm8gaW5kaWNhdGluZyBzdWNjZXNzIHRvDQo+ IHRoZSBjYWxsZXIgZXZlbiBpZiB0aGUgZnVuY3Rpb24gY2FsbCB0byBpd2xfbXZtX3NjYW5fc3Rv cCBmYWlscy4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IE5pY2hvbGFzIEtyYXVzZSA8eGVyb2ZvaWZ5 QGdtYWlsLmNvbT4NCj4gLS0tDQoNCkFwcGxpZWQgdG8gb3VyIGludGVybmFsIHRyZWUgd2l0aCBh IG1vZGlmaWVkIGNvbW1pdCBtZXNzYWdlLg0KDQpUaGFua3MhDQoNCi0tDQpMdWNhLg==