From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [v2] drm/i915/skl: Init cdclk in the driver rather than relying on pre-os Date: Thu, 08 Oct 2015 14:29:06 +0300 Message-ID: <1444303746.13547.11.camel@intel.com> References: <1444058564-13663-1-git-send-email-shobhit.kumar@intel.com> <1444278535-16483-1-git-send-email-shobhit.kumar@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A8BE6E2DB for ; Thu, 8 Oct 2015 04:29:09 -0700 (PDT) In-Reply-To: <1444278535-16483-1-git-send-email-shobhit.kumar@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Shobhit Kumar Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gdG8sIDIwMTUtMTAtMDggYXQgMDk6NTggKzA1MzAsIFNob2JoaXQgS3VtYXIgd3JvdGU6Cj4g UmV1c2Ugd2hhdCBpcyBwcm9ncmFtbWVkIGJ5IHByZS1vcywgYnV0IGluIGNhc2UgdGhlcmUgaXMg bm8gcHJlLW9zCj4gaW5pdGlhbGl6YXRpb24sIGluaXQgdGhlIGNkY2xrIHdpdGggdGhlIG1heCB2 YWx1ZSBieSBkZWZhdWx0IHVudGlsbAo+IGR5bmFtaWMgY2RjbGsgc3VwcG9ydCBjb21lcy4KPiAK PiB2MjogQ2hlY2sgaWYgQklPUyBwcm9ncmFtbWVkIGNvcnJlY3RseSByYXRoZXIgdGhhbiBhbHdh eXMgY2FsbGluZyBpbml0Cj4gICAgIC0gRG8gdmFsaWRhdGlvbiBvZiBwcm9ncmFtbWVkIGNkY3Rs IGFuZCB3aGF0IGl0IGlzIGV4cGVjdGVkCj4gICAgIC0gT25seSBkbyBzbGtfaW5pdF9jZGNsayBp ZiB2YWxpZGF0aW9uIGZhaWxlZCBlbHNlIHJldXNlIEJJT1MKPiAgICAgICBwcm9ncmFtbWVkIHZh bHVlCj4gCj4gQ2M6IEltcmUgRGVhayA8aW1yZS5kZWFrQGludGVsLmNvbT4KPiBDYzogVmlsbGUg U3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5 OiBTaG9iaGl0IEt1bWFyIDxzaG9iaGl0Lmt1bWFyQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMgICAgIHwgMTggKysrKysrKysrKysrLS0tLS0KPiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgMzkgKysrKysrKysrKysrKysr KysrKysrKysrKysrLS0tLS0tLS0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgNDIgaW5zZXJ0aW9ucygr KSwgMTUgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2RkaS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiBpbmRleCAy ZDNjYzgyLi4zZWM1NjE4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2RkaS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiBAQCAtMjk0 NiwxMSArMjk0NiwxOSBAQCB2b2lkIGludGVsX2RkaV9wbGxfaW5pdChzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2KQo+ICAJCWludCBjZGNsa19mcmVxOwo+ICAKPiAgCQljZGNsa19mcmVxID0gZGV2X3By aXYtPmRpc3BsYXkuZ2V0X2Rpc3BsYXlfY2xvY2tfc3BlZWQoZGV2KTsKPiAtCQlkZXZfcHJpdi0+ c2tsX2Jvb3RfY2RjbGsgPSBjZGNsa19mcmVxOwo+IC0JCWlmICghKEk5MTVfUkVBRChMQ1BMTDFf Q1RMKSAmIExDUExMX1BMTF9FTkFCTEUpKQo+IC0JCQlEUk1fRVJST1IoIkxDUExMMSBpcyBkaXNh YmxlZFxuIik7Cj4gLQkJZWxzZQo+IC0JCQlpbnRlbF9kaXNwbGF5X3Bvd2VyX2dldChkZXZfcHJp diwgUE9XRVJfRE9NQUlOX1BMTFMpOwo+ICsKPiArCQkvKiBJbnZhbGlkIENEQ0xLIGZyb20gQklP UyA/ICovCj4gKwkJaWYgKGNkY2xrX2ZyZXEgPCAwKSB7Cj4gKwkJCS8qIHByb2dyYW0gdG8gbWF4 aW11bSBjZGNsayB0aWxsIHdlIGhhdmUgZHluYW1pYyBjZGNsayBzdXBwb3J0ICovCj4gKwkJCWRl dl9wcml2LT5za2xfYm9vdF9jZGNsayA9IDY3NTAwMDsKPiArCQkJc2tsX2luaXRfY2RjbGsoZGV2 X3ByaXYpOwoKVGhpcyB3b3VsZCBzdGlsbCB0cnkgdG8gcmVwcm9ncmFtIENEQ0xLIGlmIEJJT1Mg ZW5hYmxlZCBhbiBvdXRwdXQgd2l0aAphbiBpbmNvcnJlY3QgQ0RDTEsgZGVjaW1hbCBwYXJ0LiBJ c24ndCB0aGlzIHRoZSBleGFjdCBzY2VuYXJpbyB5b3UncmUKc2VlaW5nPyBBcyBzYWlkIGJlZm9y ZSByZXByb2dyYW1taW5nIENEQ0xLIGluIHRoYXQgY2FzZSB3b3VsZCByZXF1aXJlCmRpc2FibGlu ZyB0aGUgb3V0cHV0cyBmaXJzdC4KCldlIHdvdWxkIGFsc28gbmVlZCB0byBjYWxsIHNrbF9pbml0 X2NkY2xrIGlmIHRoZSBCSU9TIGhhc24ndCBlbmFibGVkIHRoZQpQTEwgZm9yIHNvbWUgcmVhc29u LiBCdXQgSSBndWVzcyB0aGF0IGNvdWxkIGJlIGEgc2VwYXJhdGUgY2hhbmdlLgoKPiArCQl9IGVs c2Ugewo+ICsJCQlkZXZfcHJpdi0+c2tsX2Jvb3RfY2RjbGsgPSBjZGNsa19mcmVxOwo+ICsJCQlp ZiAoIShJOTE1X1JFQUQoTENQTEwxX0NUTCkgJiBMQ1BMTF9QTExfRU5BQkxFKSkKPiArCQkJCURS TV9FUlJPUigiTENQTEwxIGlzIGRpc2FibGVkXG4iKTsKPiArCQkJZWxzZQo+ICsJCQkJaW50ZWxf ZGlzcGxheV9wb3dlcl9nZXQoZGV2X3ByaXYsIFBPV0VSX0RPTUFJTl9QTExTKTsKPiArCQl9Cj4g IAl9IGVsc2UgaWYgKElTX0JST1hUT04oZGV2KSkgewo+ICAJCWJyb3h0b25faW5pdF9jZGNsayhk ZXYpOwo+ICAJCWJyb3h0b25fZGRpX3BoeV9pbml0KGRldik7Cj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYwo+IGluZGV4IGJiZWI2ZDMuLmY3MzQ0MTAgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTY2MzQsMTIgKzY2MzQsMTUgQEAgc3RhdGljIGlu dCBza3lsYWtlX2dldF9kaXNwbGF5X2Nsb2NrX3NwZWVkKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYp Cj4gIAl1aW50MzJfdCBsY3BsbDEgPSBJOTE1X1JFQUQoTENQTEwxX0NUTCk7Cj4gIAl1aW50MzJf dCBjZGN0bCA9IEk5MTVfUkVBRChDRENMS19DVEwpOwo+ICAJdWludDMyX3QgbGlua3JhdGU7Cj4g KwlpbnQgZnJlcTsKPiAgCj4gIAlpZiAoIShsY3BsbDEgJiBMQ1BMTF9QTExfRU5BQkxFKSkKPiAg CQlyZXR1cm4gMjQwMDA7IC8qIDI0TUh6IGlzIHRoZSBjZCBmcmVxIHdpdGggTlNTQyByZWYgKi8K PiAgCj4gLQlpZiAoKGNkY3RsICYgQ0RDTEtfRlJFUV9TRUxfTUFTSykgPT0gQ0RDTEtfRlJFUV81 NDApCj4gLQkJcmV0dXJuIDU0MDAwMDsKPiArCWlmICgoY2RjdGwgJiBDRENMS19GUkVRX1NFTF9N QVNLKSA9PSBDRENMS19GUkVRXzU0MCkgewo+ICsJCWZyZXEgPSA1NDAwMDA7Cj4gKwkJZ290byB2 ZXJpZnk7Cj4gKwl9Cj4gIAo+ICAJbGlua3JhdGUgPSAoSTkxNV9SRUFEKERQTExfQ1RSTDEpICYK PiAgCQkgICAgRFBMTF9DVFJMMV9MSU5LX1JBVEVfTUFTSyhTS0xfRFBMTDApKSA+PiAxOwo+IEBA IC02NjQ5LDMwICs2NjUyLDQ2IEBAIHN0YXRpYyBpbnQgc2t5bGFrZV9nZXRfZGlzcGxheV9jbG9j a19zcGVlZChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAJCS8qIHZjbyA4NjQwICovCj4gIAkJ c3dpdGNoIChjZGN0bCAmIENEQ0xLX0ZSRVFfU0VMX01BU0spIHsKPiAgCQljYXNlIENEQ0xLX0ZS RVFfNDUwXzQzMjoKPiAtCQkJcmV0dXJuIDQzMjAwMDsKPiArCQkJZnJlcSA9IDQzMjAwMDsKPiAr CQkJYnJlYWs7Cj4gIAkJY2FzZSBDRENMS19GUkVRXzMzN18zMDg6Cj4gLQkJCXJldHVybiAzMDg1 NzA7Cj4gKwkJCWZyZXEgPSAzMDg1NzA7Cj4gKwkJCWJyZWFrOwo+ICAJCWNhc2UgQ0RDTEtfRlJF UV82NzVfNjE3Ogo+IC0JCQlyZXR1cm4gNjE3MTQwOwo+ICsJCQlmcmVxID0gNjE3MTQwOwo+ICsJ CQlicmVhazsKPiAgCQlkZWZhdWx0Ogo+ICAJCQlXQVJOKDEsICJVbmtub3duIGNkIGZyZXEgc2Vs ZWN0aW9uXG4iKTsKPiArCQkJcmV0dXJuIC1FSU5WQUw7Cj4gIAkJfQo+ICAJfSBlbHNlIHsKPiAg CQkvKiB2Y28gODEwMCAqLwo+ICAJCXN3aXRjaCAoY2RjdGwgJiBDRENMS19GUkVRX1NFTF9NQVNL KSB7Cj4gIAkJY2FzZSBDRENMS19GUkVRXzQ1MF80MzI6Cj4gLQkJCXJldHVybiA0NTAwMDA7Cj4g KwkJCWZyZXEgPSA0NTAwMDA7Cj4gKwkJCWJyZWFrOwo+ICAJCWNhc2UgQ0RDTEtfRlJFUV8zMzdf MzA4Ogo+IC0JCQlyZXR1cm4gMzM3NTAwOwo+ICsJCQlmcmVxID0gMzM3NTAwOwo+ICsJCQlicmVh azsKPiAgCQljYXNlIENEQ0xLX0ZSRVFfNjc1XzYxNzoKPiAtCQkJcmV0dXJuIDY3NTAwMDsKPiAr CQkJZnJlcSA9IDY3NTAwMDsKPiArCQkJYnJlYWs7Cj4gIAkJZGVmYXVsdDoKPiAgCQkJV0FSTigx LCAiVW5rbm93biBjZCBmcmVxIHNlbGVjdGlvblxuIik7Cj4gKwkJCXJldHVybiAtRUlOVkFMOwo+ ICAJCX0KPiAgCX0KPiAgCj4gLQkvKiBlcnJvciBjYXNlLCBkbyBhcyBpZiBEUExMMCBpc24ndCBl bmFibGVkICovCj4gLQlyZXR1cm4gMjQwMDA7Cj4gK3ZlcmlmeToKPiArCS8qCj4gKwkgKiBOb3Rp Y2VkIGluIHNvbWUgaW5zdGFuY2VzIHRoYXQgdGhlIGZyZXEgc2VsZWN0aW9uIGlzIGNvcnJlY3Qg YnV0Cj4gKwkgKiBkZWNpbWFsIHBhcnQgaXMgcHJvZ3JhbW1lZCB3cm9uZyBmcm9tIEJJT1Mgd2hl cmUgcHJlLW9zIGRvZXMgbm90Cj4gKwkgKiBlbmFibGUgZGlzcGxheS4gVmVyaWZ5IHRoZSBzYW1l IGFzIHdlbGwuCj4gKwkgKi8KPiArCWlmIChjZGN0bCA9PSAoKGNkY3RsICYgQ0RDTEtfRlJFUV9T RUxfTUFTSykgfCBza2xfY2RjbGtfZGVjaW1hbChmcmVxKSkpCj4gKwkJcmV0dXJuIGZyZXE7Cj4g KwllbHNlCj4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4gIH0KPiAgCj4gIHN0YXRpYyBpbnQgYnJveHRv bl9nZXRfZGlzcGxheV9jbG9ja19zcGVlZChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQoKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==