From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [PATCH for-next] scsi: qla2xxx: Hide unavailable firmware Date: Thu, 08 Oct 2015 09:17:46 -0700 Message-ID: <1444321066.2312.1.camel@HansenPartnership.com> References: <1432252831-7551-1-git-send-email-julian.calaby@gmail.com> <56153682.1030801@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from bedivere.hansenpartnership.com ([66.63.167.143]:57258 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932929AbbJHQRt (ORCPT ); Thu, 8 Oct 2015 12:17:49 -0400 In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Himanshu Madhani Cc: Julian Calaby , Xose Vazquez Perez , Dept-Eng QLA2xxx Upstream , linux-scsi , Linux Firmware Maintainers On Thu, 2015-10-08 at 15:46 +0000, Himanshu Madhani wrote: > > On 10/7/15, 4:41 PM, "Julian Calaby" wrote: > > >Hi Xose, > > > >On Thu, Oct 8, 2015 at 2:13 AM, Xose Vazquez Perez > > wrote: > >> On Fri, May 22, 2015 at 10:00 AM, Julian Calaby > >> wrote: > >> > >>> Some qla2xxx devices have firmware stored in flash on the device, > >>> however for debugging and triage purposes, Qlogic staff like to > >>> be able to load known-good versions of these firmwares through > >>> request_firmware(). > >>> > >>> These firmware files were never distributed and are unlikely to ever > >>> be released publically, so to hide these missing firmware files from > >>> scripts which check such things, (e.g. Debian's initramfs-tools) put > >>> them behind a new EXPERT Kconfig option. > >> > >> > >> What is state of this patch ? > > > >Apparently nobody cared, either from qLogic or linux-scsi. > > > >I'm not overly fussed whether it goes in or not, it was more a point > >in the discussion that proceeded it, however it does solve the > >problems in the discussion that preceded it. > > This patch Looks good. > > Acked-By: Himanshu Madhani Actually, this isn't helpful. You now add another option over which the distributions have to make a choice. Is this interface necessary and useful? If yes, then it should be compiled in and if not, just remove it ... don't do death by 1000 Kconfig options. James