From: sfeldma@gmail.com
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, jiri@resnulli.us, siva.mannem.lnx@gmail.com,
pjonnala@broadcom.com, stephen@networkplumber.org,
roopa@cumulusnetworks.com, andrew@lunn.ch, f.fainelli@gmail.com,
vivien.didelot@savoirfairelinux.com
Subject: [PATCH net-next v3 2/4] switchdev: skip over ports returning -EOPNOTSUPP when recursing ports
Date: Thu, 8 Oct 2015 19:23:18 -0700 [thread overview]
Message-ID: <1444357400-37078-3-git-send-email-sfeldma@gmail.com> (raw)
In-Reply-To: <1444357400-37078-1-git-send-email-sfeldma@gmail.com>
From: Scott Feldman <sfeldma@gmail.com>
This allows us to recurse over all the ports, skipping over unsupporting
ports. Without the change, the recursion would stop at first unsupported
port.
Signed-off-by: Scott Feldman <sfeldma@gmail.com>
---
include/net/switchdev.h | 1 +
net/switchdev/switchdev.c | 9 ++++++++-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/include/net/switchdev.h b/include/net/switchdev.h
index 61f129b..1ce7083 100644
--- a/include/net/switchdev.h
+++ b/include/net/switchdev.h
@@ -16,6 +16,7 @@
#include <linux/list.h>
#define SWITCHDEV_F_NO_RECURSE BIT(0)
+#define SWITCHDEV_F_SKIP_EOPNOTSUPP BIT(1)
struct switchdev_trans_item {
struct list_head list;
diff --git a/net/switchdev/switchdev.c b/net/switchdev/switchdev.c
index 6e4a4f9..7a9ab90 100644
--- a/net/switchdev/switchdev.c
+++ b/net/switchdev/switchdev.c
@@ -147,7 +147,7 @@ static int __switchdev_port_attr_set(struct net_device *dev,
return ops->switchdev_port_attr_set(dev, attr, trans);
if (attr->flags & SWITCHDEV_F_NO_RECURSE)
- return err;
+ goto done;
/* Switch device port(s) may be stacked under
* bond/team/vlan dev, so recurse down to set attr on
@@ -156,10 +156,17 @@ static int __switchdev_port_attr_set(struct net_device *dev,
netdev_for_each_lower_dev(dev, lower_dev, iter) {
err = __switchdev_port_attr_set(lower_dev, attr, trans);
+ if (err == -EOPNOTSUPP &&
+ attr->flags & SWITCHDEV_F_SKIP_EOPNOTSUPP)
+ continue;
if (err)
break;
}
+done:
+ if (err == -EOPNOTSUPP && attr->flags & SWITCHDEV_F_SKIP_EOPNOTSUPP)
+ err = 0;
+
return err;
}
--
1.7.10.4
next prev parent reply other threads:[~2015-10-09 2:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 2:23 [PATCH net-next v3 0/4] switchdev: push bridge ageing_time attribute down sfeldma
2015-10-09 2:23 ` [PATCH net-next v3 1/4] switchdev: add bridge ageing_time attribute sfeldma
2015-10-09 4:27 ` Jiri Pirko
2015-10-09 2:23 ` sfeldma [this message]
2015-10-09 4:27 ` [PATCH net-next v3 2/4] switchdev: skip over ports returning -EOPNOTSUPP when recursing ports Jiri Pirko
2015-10-09 2:23 ` [PATCH net-next v3 3/4] bridge: push bridge setting ageing_time down to switchdev sfeldma
2015-10-09 2:40 ` Florian Fainelli
2015-10-09 3:31 ` Scott Feldman
2015-10-09 4:28 ` Jiri Pirko
2015-10-09 4:38 ` Premkumar Jonnala
2015-10-09 6:41 ` Jiri Pirko
2015-10-10 2:53 ` Scott Feldman
2015-10-10 7:04 ` Jiri Pirko
2015-10-10 15:56 ` Vivien Didelot
2015-10-10 21:09 ` Jiri Pirko
2015-10-10 22:41 ` Vivien Didelot
2015-10-11 0:07 ` Florian Fainelli
2015-10-11 22:38 ` Vivien Didelot
2015-10-12 4:39 ` Premkumar Jonnala
2015-10-13 5:39 ` Scott Feldman
2015-10-12 5:43 ` Scott Feldman
2015-10-09 2:23 ` [PATCH net-next v3 4/4] rocker: handle setting bridge ageing_time sfeldma
2015-10-09 4:28 ` Jiri Pirko
2015-10-09 2:40 ` [PATCH net-next v3 0/4] switchdev: push bridge ageing_time attribute down Florian Fainelli
2015-10-09 4:29 ` Jiri Pirko
2015-10-12 12:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444357400-37078-3-git-send-email-sfeldma@gmail.com \
--to=sfeldma@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pjonnala@broadcom.com \
--cc=roopa@cumulusnetworks.com \
--cc=siva.mannem.lnx@gmail.com \
--cc=stephen@networkplumber.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.