From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756492AbbJIOfS (ORCPT ); Fri, 9 Oct 2015 10:35:18 -0400 Received: from mga09.intel.com ([134.134.136.24]:11599 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754701AbbJIOfQ (ORCPT ); Fri, 9 Oct 2015 10:35:16 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,658,1437462000"; d="scan'208";a="807305207" Message-ID: <1444401312.8361.547.camel@linux.intel.com> Subject: Re: [PATCH v2 1/1] x86/early_printk: Use __iomem address space for IO From: Andy Shevchenko To: linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , x86@kernel.org Date: Fri, 09 Oct 2015 17:35:12 +0300 In-Reply-To: <1444400949-103551-1-git-send-email-andriy.shevchenko@linux.intel.com> References: <1444400949-103551-1-git-send-email-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-10-09 at 17:29 +0300, Andy Shevchenko wrote: > There are following warnings on unpatched code: > > arch/x86/kernel/early_printk.c:198:32: warning: incorrect type in > initializer (different address spaces) > arch/x86/kernel/early_printk.c:198:32: expected void [noderef] > *vaddr > arch/x86/kernel/early_printk.c:198:32: got unsigned int [usertype] > * > arch/x86/kernel/early_printk.c:205:32: warning: incorrect type in > initializer (different address spaces) > arch/x86/kernel/early_printk.c:205:32: expected void [noderef] > *vaddr > arch/x86/kernel/early_printk.c:205:32: got unsigned int [usertype] > * This one is wrong, sorry for noise. > > Signed-off-by: Andy Shevchenko > --- > v2: > - amend subject line > arch/x86/kernel/early_printk.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/early_printk.c > b/arch/x86/kernel/early_printk.c > index 076a4a7..77f2f5c 100644 > --- a/arch/x86/kernel/early_printk.c > +++ b/arch/x86/kernel/early_printk.c > @@ -195,14 +195,14 @@ static __init void early_serial_init(char *s) > #ifdef CONFIG_PCI > static void mem32_serial_out(unsigned long addr, int offset, int > value) > { > - u32 *vaddr = (u32 *)addr; > + void __iomem *vaddr = (void __iomem *)addr; > /* shift implied by pointer type */ > writel(value, vaddr + offset); > } > > static unsigned int mem32_serial_in(unsigned long addr, int offset) > { > - u32 *vaddr = (u32 *)addr; > + void __iomem *vaddr = (void __iomem *)addr; > /* shift implied by pointer type */ > return readl(vaddr + offset); > } -- Andy Shevchenko Intel Finland Oy