From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754699AbbJIPKm (ORCPT ); Fri, 9 Oct 2015 11:10:42 -0400 Received: from mga09.intel.com ([134.134.136.24]:33367 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752801AbbJIPKl (ORCPT ); Fri, 9 Oct 2015 11:10:41 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,658,1437462000"; d="scan'208";a="788579834" Message-ID: <1444403436.8361.550.camel@linux.intel.com> Subject: Re: [PATCH 1/1] x86/intel-mid: modify a code to suppress a warning From: Andy Shevchenko To: Thomas Gleixner Cc: linux-kernel@vger.kernel.org, Ingo Molnar , "H . Peter Anvin" , x86@kernel.org Date: Fri, 09 Oct 2015 18:10:36 +0300 In-Reply-To: References: <1444397355-82695-1-git-send-email-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-10-09 at 16:01 +0200, Thomas Gleixner wrote: > On Fri, 9 Oct 2015, Andy Shevchenko wrote: > > Please stop to write subject lines like this. > > x86/intel-mid: modify a code to suppress a warning > > This is completely useless as it does not tell what kind of warning > (compile time, runtime). Further it says that the patch modifies > code, which is completely pointless, right? > > What's wrong with: > > x86/intel-mid: Make intel_mid_ops static > > I end up rewriting your subject lines and changelogs on a regular > base. You really should have noticed that by now and started to spend > a little bit more effort yourself. Thank you. > > Thanks, > > tglx > > -- Andy Shevchenko Intel Finland Oy