Re: [PATCH 3/3] reiser4: in our own sync writes, mark pages dirty before marking them writeback.

[Ivan Shapovalov <intelfx100@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1627 bytes --]

On 2015-10-09 at 12:27 -0400, Oleg Drokin wrote:
> On Oct 9, 2015, at 12:13 PM, Ivan Shapovalov wrote:
> 
> > On 2015-10-09 at 16:55 +0200, Edward Shishkin wrote:
> > 
> > > 
> > > On 10/09/2015 03:50 PM, Ivan Shapovalov wrote:
> > 
> > > > On 2015-10-09 at 15:27 +0200, Edward Shishkin wrote:
> > 
> > > > > Hi Ivan,
> > > > > 
> > > > > On 10/09/2015 01:16 PM, Ivan Shapovalov wrote:
> > 
> > > > > > Ref.: https://www.mail-archive.com/linux-f2fs-devel%40lists
> > > > > > .sou
> > > > > > rcef
> > > > > > orge.net/msg02745.html
> > > > > Do you have a stack trace for reiser4?
> > > > > How to reproduce it?
> > > > I'll rebuild the kernel without the fix and provide you with
> > > > the
> > > > oops'
> > > > stacktrace asap.
> > > > 
> > > > I guess that it's tied to the config. In my case, it is
> > > > reproducible on
> > > > each boot, just as the DE starts up and something issues the
> > > > first
> > > > fsync().
> > > 
> > > 
> > > Yes, let's try to find the culprit who doesn't set i_wb...
> > 
> > So, here is the oops:
> 
> I suspect this will not help you much.
> What you probably need to do is to add an assertion of some sort when
> the page
> is inserted into this list (on which you later do waiting for
> writeback) and
> it's not dirty.
> Either that or you might be able to see in the coe right away where
> such
> addition is made without markign the page dirty.

Indeed. I'm thinking the same as I read the code.
Did I say that I don't know neither reiser4 nor VFS well?.. :)

Thanks for the advice, anyway.

-- 
Ivan Shapovalov / intelfx /


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 213 bytes --]