From: Chandan Rajendra <chandan@linux.vnet.ibm.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
"linux-unionfs@vger.kernel.org" <linux-unionfs@vger.kernel.org>
Subject: Re: [PATCH v3 5/5] ovl: consistent st_ino/d_ino
Date: Thu, 03 Aug 2017 12:48:46 +0530 [thread overview]
Message-ID: <14445672.Uv0dO8JY0o@localhost.localdomain> (raw)
In-Reply-To: <CAOQ4uxif79cbhYJxgHzkG0jpNgginMimvfgm-iSXAnuRkmWUqw@mail.gmail.com>
On Friday, July 28, 2017 2:55:56 PM IST Amir Goldstein wrote:
> On Thu, Jul 27, 2017 at 11:00 PM, Miklos Szeredi <miklos@szeredi.hu> wrote:
> > On Wed, Jun 21, 2017 at 11:48 AM, Miklos Szeredi <miklos@szeredi.hu> wrote:
> >> On Wed, Jun 21, 2017 at 11:36 AM, Amir Goldstein <amir73il@gmail.com> wrote:
> >>> On Wed, Jun 21, 2017 at 12:20 PM, Miklos Szeredi <miklos@szeredi.hu> wrote:
> >>>> On Wed, Jun 21, 2017 at 11:05 AM, Amir Goldstein <amir73il@gmail.com> wrote:
> >>>
> >>>>>
> >>>>> Following up on your idea:
> >>>>> - check in ovl_iterate() if version has changed and if dir became impure
> >>>>> - if it did, populate od->cache, but keep the dir od->is_real
> >>>>> - iterate upper cache entries and call ovl_cache_update_ino()
> >>>>> - Then actor of real dir iterator can use the cache to ommit entries or use
> >>>>> p->ino from cache if p->real_ino match real d_ino, but differs from p->ino.
> >>>>
> >>>> For non-merge dirs we can have a simplified cache just containing the
> >>>> entries with origin, recreated when the version changes or updated in
> >>>> rename, whichever is simpler. A non-merge dir will never become a
> >>>> merge one, so we can keep the handling separate.
> >>>>
> >>>
> >>> And use this cache to ommit/fix entries with actor?
> >>
> >> Right. I think fixing up is better, because to correctly omit entries
> >> we'd need separate lists for each open directory. For fixing up we
> >> can use a common one, just like for the merged dir.
> >
> > And back to this, I pushed a branch named "ovl-d_ino" to my vfs tree.
> >
> > Please test.
> >
>
> I can confirm that xfstest overlay/017, the only test I have for
> constant d_ino,
> passes. Although it does not cover all cases handled by the patch set
> (e.g. d_ino of merge parent).
>
> Chandan,
>
> Can you take on the task of improving test coverage for constant d_ino?
> You should create a new xfstest and cover more cases of constant d_ino
> and possibly also a test for clearing of impure xattr.
>
> When the basic test is in place, I will be able to point at more corner cases
> to cover.
>
> Also need to prepare a test to verify constant d_ino for non samefs
> for after this patch is integrated with your work.
> overlay/017 is a good starting point, but can't use the standard _scratch_mount
> helpers that mount samefs overlay.
Hi Amir,
In ovl_calc_d_ino() we have the following code snippet,
if ((p->name[0] == '.' && p->len == 1) ||
ovl_test_flag(OVL_IMPURE, d_inode(rdd->dentry)))
return true;
At this point in the function, the directory which is being iterated must have
an entry in upperdir. W.r.t the case of processing "." directory entry, I
think we can limit it to be applicable only when rdd->dentry is either a merge
dir or an impure dir. For a directory which is both pure and non-merge, we can
return the value of p->ino as is.
The second part of the "if" condition takes care of the 'impure dir' part. So
the first part of the "if" condition can be written as,
(p->name[0] == '.' && p->len == 1 && !OVL_TYPE_MERGE(ovl_path_type(rdd->dentry)))
--
chandan
next prev parent reply other threads:[~2017-08-03 7:18 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 9:02 [PATCH v3 0/5] ovl: constant inode numbers (cont.) Amir Goldstein
2017-06-01 9:02 ` [PATCH v3 1/5] ovl: relax same fs constrain for ovl_check_origin() Amir Goldstein
2017-06-01 9:02 ` [PATCH v3 2/5] ovl: relax same fs constrain for constant st_ino Amir Goldstein
2017-06-01 12:30 ` Chandan Rajendra
2017-06-01 13:32 ` Amir Goldstein
2017-06-01 19:55 ` Miklos Szeredi
2017-06-02 6:32 ` Amir Goldstein
2017-06-02 12:27 ` Miklos Szeredi
2017-06-02 13:23 ` Amir Goldstein
2017-06-02 13:26 ` Miklos Szeredi
2017-06-02 13:34 ` Amir Goldstein
2017-06-01 9:02 ` [PATCH v3 3/5] vfs: factor out lookup_one_len_init() Amir Goldstein
2017-06-01 9:02 ` [PATCH v3 4/5] vfs: add helper lookup_one_len_noperm() Amir Goldstein
2017-06-05 12:36 ` Amir Goldstein
2017-06-01 9:02 ` [PATCH v3 5/5] ovl: consistent st_ino/d_ino Amir Goldstein
2017-06-20 21:25 ` Miklos Szeredi
2017-06-21 8:03 ` Amir Goldstein
2017-06-21 8:20 ` Miklos Szeredi
2017-06-21 8:38 ` Miklos Szeredi
2017-06-21 8:45 ` Miklos Szeredi
2017-06-21 8:49 ` Amir Goldstein
2017-06-21 8:53 ` Miklos Szeredi
2017-06-21 9:05 ` Amir Goldstein
2017-06-21 9:20 ` Miklos Szeredi
2017-06-21 9:36 ` Amir Goldstein
2017-06-21 9:38 ` Amir Goldstein
2017-06-21 9:48 ` Miklos Szeredi
2017-06-23 13:56 ` Amir Goldstein
2017-06-30 16:23 ` Chandan Rajendra
2017-06-30 19:01 ` Amir Goldstein
2017-07-27 20:00 ` Miklos Szeredi
2017-07-28 9:25 ` Amir Goldstein
2017-07-29 10:33 ` Amir Goldstein
2017-07-31 10:58 ` Miklos Szeredi
2017-08-16 11:16 ` Amir Goldstein
2017-07-29 11:26 ` Chandan Rajendra
2017-08-03 7:18 ` Chandan Rajendra [this message]
2017-08-03 9:53 ` Chandan Rajendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14445672.Uv0dO8JY0o@localhost.localdomain \
--to=chandan@linux.vnet.ibm.com \
--cc=amir73il@gmail.com \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.