From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: patch "x86/cpufreq: relocate the driver register
 function" breaks cpu hot(un)plug
Date: Mon, 12 Oct 2015 15:22:46 +0200
Message-ID: <1444656166.3009.17.camel@citrix.com>
References: <1444409303.3009.5.camel@citrix.com>
	<20151009200059.GD23382@l.oracle.com>
	<561BCF6502000078000AA41A@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4660215918746947061=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=720d8fb3f=dario.faggioli@citrix.com>)
	id 1Zld41-000624-SB
	for xen-devel@lists.xenproject.org; Mon, 12 Oct 2015 13:22:54 +0000
In-Reply-To: <561BCF6502000078000AA41A@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Wei Wang <wei.w.wang@intel.com>
List-Id: xen-devel@lists.xenproject.org

--===============4660215918746947061==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-zPGEAuCRjUV/bv3lkWQv"

--=-zPGEAuCRjUV/bv3lkWQv
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2015-10-12 at 07:19 -0600, Jan Beulich wrote:
> > > > On 09.10.15 at 22:00, <konrad.wilk@oracle.com> wrote:
> > Anyhow it may be due to the fact that cpufreq_register_driver in
> > Xen is now
> > '__init' If you remove that little thing would it work?
>=20
> Before adding this annotation I carefully check all callers, and both
> which I could find are themselves __init. Did I overlook any?
>=20
No, I've just checked, and I also think __init is fine. And in fact, I
tried removing it, and the issue is still there.

I think the issue is the fact that we register the cpu notifier twice,
as an effect of 49388f11d512bb92706ce046643bfbb3c1d963c9, as Wei noted.

I'm just about try and confirm that...

Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-zPGEAuCRjUV/bv3lkWQv
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEABECAAYFAlYbtCYACgkQk4XaBE3IOsRGJwCdFXwd0Ui2rRNPIRjkpcCeG44g
gnsAn0IT3J22+aGH5/5p24ABqock2JEw
=DppA
-----END PGP SIGNATURE-----

--=-zPGEAuCRjUV/bv3lkWQv--


--===============4660215918746947061==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============4660215918746947061==--