From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: patch "x86/cpufreq: relocate the driver register
 function" breaks cpu hot(un)plug
Date: Mon, 12 Oct 2015 15:34:49 +0200
Message-ID: <1444656889.3009.25.camel@citrix.com>
References: <1444409303.3009.5.camel@citrix.com>
	<20151009200059.GD23382@l.oracle.com>
	<286AC319A985734F985F78AFA26841F7A7256A@shsmsx102.ccr.corp.intel.com>
	<561BD04502000078000AA436@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2027275839919584820=="
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=720d8fb3f=dario.faggioli@citrix.com>)
	id 1ZldFf-0006ji-0T
	for xen-devel@lists.xenproject.org; Mon, 12 Oct 2015 13:34:55 +0000
In-Reply-To: <561BD04502000078000AA436@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, Wei W Wang <wei.w.wang@intel.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
List-Id: xen-devel@lists.xenproject.org

--===============2027275839919584820==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-UkANC8vWiujlrHLrhFll"

--=-UkANC8vWiujlrHLrhFll
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2015-10-12 at 07:22 -0600, Jan Beulich wrote:
> > > > On 10.10.15 at 03:38, <wei.w.wang@intel.com> wrote:
> > On 09/10/2015 04:01, Konrad Rzeszutek Wilk wrote:

> > Please also remove "register_cpu_notifier(&cpu_nfb)" in the=20
> > cpufreq_register_driver function as well. (found that it has
> > already been=20
> > included in cpufreq_presmp_nfb()).
>=20
> Yes, I think this is it, and I seem to recall having complained about
> this in an earlier version of the series (and I overlooked it now).
>
In fact, I did not spot it with `git diff' either (and the changelog
says "Move the driver register function"!).

> Dario, if could you let us know whether that helps?
>=20
Yep, I confirm that it was it. Avoiding calling register_cpu_notifier()
from cpufreq_register_driver(), I am able to put CPUs offline and then
back online again.

I've got to go AFK for a bit now, but I'm fine sending a patch later in
the afternoon. If someone wants to try beating me, no hard feelings.
:-)

Thanks and Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-UkANC8vWiujlrHLrhFll
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEABECAAYFAlYbtvkACgkQk4XaBE3IOsTt5ACfRtVJbqkUHuj2r3PCivTRESrH
cNsAnRrV4ncb2znRsQB+xgvALJ/S8Ruf
=oZlo
-----END PGP SIGNATURE-----

--=-UkANC8vWiujlrHLrhFll--


--===============2027275839919584820==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============2027275839919584820==--