From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: John Garry <john.garry@huawei.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
michaelc@cs.wisc.edu, linux-scsi@vger.kernel.org, hare@suse.de,
zhangfei <zhangfei.gao@linaro.org>,
john.garry2@mail.dcu.ie, "xuwei (O)" <xuwei5@hisilicon.com>
Subject: Re: SSP frame iu defines
Date: Mon, 12 Oct 2015 07:55:20 -0700 [thread overview]
Message-ID: <1444661720.2205.5.camel@HansenPartnership.com> (raw)
In-Reply-To: <56168208.2020404@huawei.com>
On Thu, 2015-10-08 at 15:47 +0100, John Garry wrote:
> On 08/10/2015 15:22, Arnd Bergmann wrote:
> > On Thursday 08 October 2015 15:17:49 John Garry wrote:
> >> Hi,
> >>
> >> For a new driver I am preparing for a SAS controller, I need defintions
> >> for the SSP command and TMF iu structures. Currently these are defined
> >> in the following:
> >> ssp_command_iu, ssp_task_iu: drivers/scsi/aic94xx_sas.h
> >> ssp_cmd_iu, ssp_task_iu: drivers/scsi/isci/sas.h
> >>
> >> I plan to move them to include/scsi/sas.h . Any objections?
> >
> > Hi John,
> >
> > I think a question like this is better asked by sending a patch,
> > to make it easier to see what the resulting change is.
> >
> > Arnd
> >
> >
> OK, can I put this together.
> I feel that the code may get messy due to byte-ordering difference in
> isci versions.
That's why we develop with the show me the code model. Rather than
arguing theoretically about whether something should or should not be
done, you propose the actual change. If it looks like a dog's breakfast
and all attempts to clean it up fail, chances are it's a bad change and
it won't go in. However, if it looks good, chances are it will.
James
next prev parent reply other threads:[~2015-10-12 14:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 14:17 SSP frame iu defines John Garry
2015-10-08 14:22 ` Arnd Bergmann
2015-10-08 14:47 ` John Garry
2015-10-12 14:46 ` Hannes Reinecke
2015-10-12 14:55 ` James Bottomley [this message]
2015-10-13 17:17 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444661720.2205.5.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=arnd@arndb.de \
--cc=hare@suse.de \
--cc=john.garry2@mail.dcu.ie \
--cc=john.garry@huawei.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=xuwei5@hisilicon.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.