From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754543AbbJNVA7 (ORCPT ); Wed, 14 Oct 2015 17:00:59 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:38803 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933010AbbJNVAl (ORCPT ); Wed, 14 Oct 2015 17:00:41 -0400 From: "Amanieu d'Antras" To: linux-kernel@vger.kernel.org Cc: Oleg Nesterov , Andrew Morton , "Paul E. McKenney" , x86@kernel.org, Brian Gerst , "Amanieu d'Antras" Subject: [PATCH 20/20] signal: Remove unnecessary zero-initialization of siginfo_t Date: Wed, 14 Oct 2015 21:59:31 +0100 Message-Id: <1444856371-26319-22-git-send-email-amanieu@gmail.com> X-Mailer: git-send-email 2.6.1 In-Reply-To: <1444856371-26319-1-git-send-email-amanieu@gmail.com> References: <1444856371-26319-1-git-send-email-amanieu@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is no longer required since copy_siginfo_from_user32 now initializes all siginfo_t fields properly. Signed-off-by: Amanieu d'Antras --- kernel/ptrace.c | 1 - kernel/signal.c | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/kernel/ptrace.c b/kernel/ptrace.c index 787320d..3aa383b 100644 --- a/kernel/ptrace.c +++ b/kernel/ptrace.c @@ -1147,7 +1147,6 @@ int compat_ptrace_request(struct task_struct *child, compat_long_t request, break; case PTRACE_SETSIGINFO: - memset(&siginfo, 0, sizeof siginfo); if (copy_siginfo_from_user32( &siginfo, (struct compat_siginfo __user *) datap)) ret = -EFAULT; diff --git a/kernel/signal.c b/kernel/signal.c index 873e8e2..ce992f2 100644 --- a/kernel/signal.c +++ b/kernel/signal.c @@ -3022,7 +3022,7 @@ COMPAT_SYSCALL_DEFINE3(rt_sigqueueinfo, int, sig, struct compat_siginfo __user *, uinfo) { - siginfo_t info = {}; + siginfo_t info; int ret = copy_siginfo_from_user32(&info, uinfo); if (unlikely(ret)) return ret; @@ -3066,7 +3066,7 @@ COMPAT_SYSCALL_DEFINE4(rt_tgsigqueueinfo, int, sig, struct compat_siginfo __user *, uinfo) { - siginfo_t info = {}; + siginfo_t info; if (copy_siginfo_from_user32(&info, uinfo)) return -EFAULT; -- 2.6.1