All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phil Blundell <pb@pbcl.net>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/2] ARM: handle missing thumb suffix
Date: Thu, 15 Oct 2015 14:39:37 +0100	[thread overview]
Message-ID: <1444916377.5251.86.camel@pbcl.net> (raw)
In-Reply-To: <20151015120934.GD2588@jama>

On Thu, 2015-10-15 at 14:09 +0200, Martin Jansa wrote:
> What about consistency with less specific PACKAGE_ARCHs which use "t" 
> to show if it was built with or without thumb?

For the generic architectures, the trailing "t" does serve a useful
purpose.  There exist ARMv5 CPUs that can't run Thumb code (I think
Marvell had some for example) which means it is useful to be able to
draw a distinction between binaries which require Thumb instructions
(armv5t) and those which require only the ARM base instruction set
(armv5).  There are a few places where the support for this in OE is a
bit rough around the edges (it doesn't get armv4 vs armv4t exactly
right) but in general it is close enough and does the right thing in
all the cases that matter.

To turn your question round, what about consistency with more specific
PACKAGE_ARCHs?  We don't use "qemuarmt" or "om-gta01t" for binaries
that happen to be built with Thumb enabled.

p.



      reply	other threads:[~2015-10-15 13:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-13 20:37 [PATCH 2/2] ARM: handle missing thumb suffix Jens Rehsack
2015-10-13 21:18 ` Martin Jansa
2015-10-15 10:49 ` Phil Blundell
2015-10-15 11:18   ` Jens Rehsack
2015-10-15 11:31   ` Martin Jansa
2015-10-15 11:51     ` Phil Blundell
2015-10-15 12:09       ` Martin Jansa
2015-10-15 13:39         ` Phil Blundell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444916377.5251.86.camel@pbcl.net \
    --to=pb@pbcl.net \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.